Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1413033006: Reland "[es6] Better support for built-ins subclassing." (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[es6] Better support for built-ins subclassing." Original issue's description: > [es6] Better support for built-ins subclassing. > > Create proper initial map for original constructor (new.target) instead of doing prototype > transition on the base constructor's initial map. This approach fixes in-object slack tracking > for subclass instances. > This CL also fixes subclassing from String. > > BUG=v8:3101, v8:3330 > LOG=Y > > Committed: https://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c > Cr-Commit-Position: refs/heads/master@{#31680} It also fixes typed array map smashing done during typed array initialization. BUG=v8:3101, v8:3330, v8:4419 LOG=Y Committed: https://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06 Cr-Commit-Position: refs/heads/master@{#31701}

Patch Set 1 : Original CL #

Patch Set 2 : We don't need TypedArray map smashing anymore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+791 lines, -146 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +33 lines, -13 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 5 chunks +24 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 chunks +0 lines, -22 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 5 chunks +28 lines, -4 lines 0 comments Download
M src/mips/builtins-mips.cc View 5 chunks +21 lines, -4 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 5 chunks +21 lines, -4 lines 0 comments Download
M src/objects.h View 5 chunks +20 lines, -6 lines 0 comments Download
M src/objects.cc View 4 chunks +130 lines, -16 lines 0 comments Download
M src/objects-inl.h View 3 chunks +19 lines, -8 lines 0 comments Download
M src/objects-printer.cc View 5 chunks +30 lines, -18 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +19 lines, -34 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +27 lines, -4 lines 0 comments Download
A test/mjsunit/es6/classes-subclass-builtins.js View 1 1 chunk +412 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (19 generated)
Igor Sheludko
PTAL
5 years, 1 month ago (2015-10-30 14:13:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033006/20001
5 years, 1 month ago (2015-10-30 14:14:15 UTC) #4
Benedikt Meurer
LGTM (rubber-stamped)
5 years, 1 month ago (2015-10-30 14:14:58 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033006/60001
5 years, 1 month ago (2015-10-30 16:01:16 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/11237)
5 years, 1 month ago (2015-10-30 16:34:22 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033006/80001
5 years, 1 month ago (2015-10-30 17:21:23 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 17:55:14 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033006/100001
5 years, 1 month ago (2015-11-02 07:58:47 UTC) #19
Igor Sheludko
PTAL I removed harmful typed array map smashing because 1) the object we create already ...
5 years, 1 month ago (2015-11-02 08:07:58 UTC) #23
Benedikt Meurer
Nice, thanks. LGTM
5 years, 1 month ago (2015-11-02 08:12:11 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033006/100001
5 years, 1 month ago (2015-11-02 08:13:45 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7275)
5 years, 1 month ago (2015-11-02 08:16:06 UTC) #29
ulan
lgtm
5 years, 1 month ago (2015-11-02 08:22:51 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033006/100001
5 years, 1 month ago (2015-11-02 08:23:45 UTC) #33
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 1 month ago (2015-11-02 08:25:26 UTC) #34
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 08:26:02 UTC) #35
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06
Cr-Commit-Position: refs/heads/master@{#31701}

Powered by Google App Engine
This is Rietveld 408576698