Issue 141303002: Remove runtime flag check assert on public method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141303002: Remove runtime flag check assert on public method. (Closed)

Created:
6 years, 11 months ago by maheshkk

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Remove runtime flag check assert on public method. WebFrame::sendOrientationChangeEvent is public method and could be called without runtime flag enabled. BUG=335258 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165293

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	Source/core/frame/DOMWindow.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/web/WebFrameImpl.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

maheshkk

Runtime feature check for orientationEvent is handled in Frame::sendOrientationChangeEvent. Public exported method in WebFrame should ...

6 years, 11 months ago (2014-01-16 23:30:31 UTC) #1

maheshkk

On 2014/01/16 23:30:31, maheshkk wrote: > Runtime feature check for orientationEvent is handled in > ...

6 years, 11 months ago (2014-01-16 23:52:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/141303002/50001

6 years, 11 months ago (2014-01-17 06:55:14 UTC) #4

Message was sent while issue was closed.

Change committed as 165293