Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1413023002: [test] Run webkit tests as part of default testing on the bots. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Run webkit tests as part of default testing on the bots. The test suite is ran in 60% of the bots anyway and the step is very short. For swarming, it's better to run this together in one step as each step triggers a different bot. BUG=chromium:535160 LOG=n NOTRY=true Committed: https://crrev.com/c8f7583a48c8391f3a3620bafd20537f1a2d55a5 Cr-Commit-Position: refs/heads/master@{#31360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/run-tests.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 2 months ago (2015-10-19 08:08:33 UTC) #2
Jakob Kummerow
LGTM. For the record: we discussed simply adding webkit tests to the default set, but ...
5 years, 2 months ago (2015-10-19 08:53:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413023002/1
5 years, 2 months ago (2015-10-19 08:53:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 08:54:58 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 08:55:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8f7583a48c8391f3a3620bafd20537f1a2d55a5
Cr-Commit-Position: refs/heads/master@{#31360}

Powered by Google App Engine
This is Rietveld 408576698