Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1413003008: Support fast-path allocation for subclass constructors with correctly initialized initial maps. (Closed)

Created:
5 years, 1 month ago by Toon Verwaest
Modified:
5 years, 1 month ago
Reviewers:
Igor Sheludko, v8-mips-ports
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support fast-path allocation for subclass constructors with correctly initialized initial maps. BUG=v8:3330 LOG=n Committed: https://crrev.com/b9d25d86a8d57be6184e2610c53c9b8abfd96f11 Cr-Commit-Position: refs/heads/master@{#31913}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Adding mips port #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -42 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 4 5 2 chunks +12 lines, -6 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 4 2 chunks +13 lines, -6 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 2 chunks +11 lines, -5 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 2 chunks +11 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Toon Verwaest
ishell: ptal v8-mips-ports: please port to mips
5 years, 1 month ago (2015-11-09 16:06:46 UTC) #2
paul.l...
Please find mips ports in https://codereview.chromium.org/1415393005/
5 years, 1 month ago (2015-11-09 17:39:09 UTC) #3
Igor Sheludko
As discussed offline, for the case (constructor == original_constructor) we don't need these new checks. ...
5 years, 1 month ago (2015-11-10 08:08:53 UTC) #4
Toon Verwaest
Addressed comment. True that we don't need to check for jsfunction, but I'll defer introducing ...
5 years, 1 month ago (2015-11-10 08:13:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413003008/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413003008/80001
5 years, 1 month ago (2015-11-10 08:13:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/9967)
5 years, 1 month ago (2015-11-10 08:18:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413003008/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413003008/100001
5 years, 1 month ago (2015-11-10 08:31:07 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-11-10 08:50:49 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 08:51:29 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b9d25d86a8d57be6184e2610c53c9b8abfd96f11
Cr-Commit-Position: refs/heads/master@{#31913}

Powered by Google App Engine
This is Rietveld 408576698