Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1413003005:
Set gpu memory policy in UI compositor. (Closed)
|
Created:
5 years, 1 month ago by sohanjg Modified:
5 years, 1 month ago CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSet gpu memory policy in UI compositor.
Now that GpuMemoryManager doesnt decide memory limit for the tilemanager,
we need to set the limits while initializing both ui and renderer compositor.
BUG=546653
Committed: https://crrev.com/db8e72689d3a39792b54bb9d3df74d3c3f264503
Cr-Commit-Position: refs/heads/master@{#357844}
Patch Set 1 #
Total comments: 3
Patch Set 2 : add todo. #Patch Set 3 : resolve bot failures. #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Set gpu memory policy in UI compositor. BUG=546653 ========== to ========== Set gpu memory policy in UI compositor. Now that GpuMemoryManager doesnt decide memory limit for the tilemanager, we need to set the limits while initializing both ui and renderer compositor. BUG=546653 ==========
sohan.jyoti@samsung.com changed reviewers: + danakj@chromium.org, piman@chromium.org
Description was changed from ========== Set gpu memory policy in UI compositor. Now that GpuMemoryManager doesnt decide memory limit for the tilemanager, we need to set the limits while initializing both ui and renderer compositor. BUG=546653 ========== to ========== Set gpu memory policy in UI compositor. Now that GpuMemoryManager doesnt decide memory limit for the tilemanager, we need to set the limits while initializing both ui and renderer compositor. BUG=546653 ==========
Please take a look, thanks. https://codereview.chromium.org/1413003005/diff/1/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/1413003005/diff/1/ui/compositor/compositor.cc... ui/compositor/compositor.cc:169: #if !defined(OS_ANDROID) will android ever be using this ? we use compositorimplandroid there, isnt it ? or future aura plans ?
lgtm https://codereview.chromium.org/1413003005/diff/1/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/1413003005/diff/1/ui/compositor/compositor.cc... ui/compositor/compositor.cc:169: #if !defined(OS_ANDROID) On 2015/11/03 12:50:00, sohanjg wrote: > will android ever be using this ? we use compositorimplandroid there, isnt it ? > or future aura plans ? Android may be using it. This is probably ok as a first approximation, but maybe add a TODO to revisit?
https://codereview.chromium.org/1413003005/diff/1/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/1413003005/diff/1/ui/compositor/compositor.cc... ui/compositor/compositor.cc:169: #if !defined(OS_ANDROID) On 2015/11/03 16:44:07, piman (slow to review) wrote: > On 2015/11/03 12:50:00, sohanjg wrote: > > will android ever be using this ? we use compositorimplandroid there, isnt it > ? > > or future aura plans ? > > Android may be using it. This is probably ok as a first approximation, but maybe > add a TODO to revisit? Done.
The CQ bit was checked by sohan.jyoti@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413003005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413003005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by sohan.jyoti@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413003005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413003005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by piman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/1413003005/#ps40001 (title: "resolve bot failures.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413003005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413003005/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/db8e72689d3a39792b54bb9d3df74d3c3f264503 Cr-Commit-Position: refs/heads/master@{#357844} |
