chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc - Issue 14130005: Remove unintended options_page support from platform apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

Issue 14130005: Remove unintended options_page support from platform apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use manifest features instead, add test case Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/_manifest_features.json ('k') | chrome/test/data/extensions/manifest_tests/platform_app_with_options_page.json » ('j') | chrome/test/data/extensions/manifest_tests/platform_app_with_options_page.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

index 6d2728ef7d40653c8109170dd74ee07d5f2debf3..47fc9167e489017f1fcb863b36139c87067f8238 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

@@ -32,6 +32,9 @@ TEST_F(OptionsPageManifestTest, OptionsPageInApps) {

extensions::ManifestURL::

GetOptionsPage(extension).ExtractFileName().c_str());

+ extension = LoadAndExpectSuccess("platform_app_with_options_page.json");

Yoyo Zhou 2013/04/16 20:11:40 Maybe add a comment here: // Platforms apps do not

+ EXPECT_TRUE(extensions::ManifestURL::GetOptionsPage(extension).is_empty());

Testcase testcases[] = {

// Forbid options page with relative URL in hosted apps.

Testcase("hosted_app_relative_options.json",