Remove unintended options_page support from platform apps.

Remove unintended options_page support from platform apps.

Platform apps do not use an Options page. This change makes OptionsPageHandler
a no-op when parsing a platform app manifest.

BUG=229584
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194801

[Yoyo Zhou, 2013-04-16 18:50:12]

Can you change _manifest_features.json instead? That should make it unrecognized
for platform apps.

[Yoyo Zhou, 2013-04-16 18:51:34]

On 2013/04/16 18:50:12, Yoyo Zhou wrote:
> Can you change _manifest_features.json instead? That should make it
unrecognized
> for platform apps.

Also, consider adding a unit test to extension_manifests_options_unittest.cc.

[Ken Rockot(use gerrit already), 2013-04-16 19:56:24]

Thanks, changes made

[Yoyo Zhou, 2013-04-16 20:11:40]

LGTM

https://codereview.chromium.org/14130005/diff/5001/chrome/common/extensions/m...
File
chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc
(right):

https://codereview.chromium.org/14130005/diff/5001/chrome/common/extensions/m...
chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc:35:
extension = LoadAndExpectSuccess("platform_app_with_options_page.json");
Maybe add a comment here: // Platforms apps do not support options pages.

https://codereview.chromium.org/14130005/diff/5001/chrome/test/data/extension...
File
chrome/test/data/extensions/manifest_tests/platform_app_with_options_page.json
(right):

https://codereview.chromium.org/14130005/diff/5001/chrome/test/data/extension...
chrome/test/data/extensions/manifest_tests/platform_app_with_options_page.json:3:
"description" : "I specify an options_page but it should be ignored.",
nit: no space before :

[commit-bot: I haz the power, 2013-04-17 23:56:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/14130005/11001

[commit-bot: I haz the power, 2013-04-18 06:19:13]

Change committed as 194801