Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: src/x87/builtins-x87.cc

Issue 1412953007: [Interpreter] Fill out function prologue support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/builtins-x64.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
624 624
625 // TODO(rmcilroy): List of things not currently dealt with here but done in 625 // TODO(rmcilroy): List of things not currently dealt with here but done in
626 // fullcodegen's prologue: 626 // fullcodegen's prologue:
627 // - Support profiler (specifically profiling_counter). 627 // - Support profiler (specifically profiling_counter).
628 // - Call ProfileEntryHookStub when isolate has a function_entry_hook. 628 // - Call ProfileEntryHookStub when isolate has a function_entry_hook.
629 // - Allow simulator stop operations if FLAG_stop_at is set. 629 // - Allow simulator stop operations if FLAG_stop_at is set.
630 // - Deal with sloppy mode functions which need to replace the 630 // - Deal with sloppy mode functions which need to replace the
631 // receiver with the global proxy when called as functions (without an 631 // receiver with the global proxy when called as functions (without an
632 // explicit receiver object). 632 // explicit receiver object).
633 // - Code aging of the BytecodeArray object. 633 // - Code aging of the BytecodeArray object.
634 // - Supporting FLAG_trace.
635 //
636 // The following items are also not done here, and will probably be done using
637 // explicit bytecodes instead:
638 // - Allocating a new local context if applicable.
639 // - Setting up a local binding to the this function, which is used in
640 // derived constructors with super calls.
641 // - Setting new.target if required.
642 // - Dealing with REST parameters (only if
643 // https://codereview.chromium.org/1235153006 doesn't land by then).
644 // - Dealing with argument objects.
645 634
646 // Perform stack guard check. 635 // Perform stack guard check.
647 { 636 {
648 Label ok; 637 Label ok;
649 ExternalReference stack_limit = 638 ExternalReference stack_limit =
650 ExternalReference::address_of_stack_limit(masm->isolate()); 639 ExternalReference::address_of_stack_limit(masm->isolate());
651 __ cmp(esp, Operand::StaticVariable(stack_limit)); 640 __ cmp(esp, Operand::StaticVariable(stack_limit));
652 __ j(above_equal, &ok); 641 __ j(above_equal, &ok);
653 __ CallRuntime(Runtime::kStackGuard, 0); 642 __ CallRuntime(Runtime::kStackGuard, 0);
654 __ bind(&ok); 643 __ bind(&ok);
(...skipping 1188 matching lines...) Expand 10 before | Expand all | Expand 10 after
1843 1832
1844 __ bind(&ok); 1833 __ bind(&ok);
1845 __ ret(0); 1834 __ ret(0);
1846 } 1835 }
1847 1836
1848 #undef __ 1837 #undef __
1849 } // namespace internal 1838 } // namespace internal
1850 } // namespace v8 1839 } // namespace v8
1851 1840
1852 #endif // V8_TARGET_ARCH_X87 1841 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/builtins-x64.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698