Not Submitted - Add OWNERS for Experimental Framework

Add OWNERS for Experimental Framework

BUG=543141

[chasej, 2015-11-02 16:11:33]

Description was changed from

==========
Add OWNERS for Experiment Framework

BUG=543141
==========

to

==========
Add OWNERS for Experiment Framework

BUG=543141
==========

[chasej, 2015-11-02 16:11:47]

Description was changed from

==========
Add OWNERS for Experiment Framework

BUG=543141
==========

to

==========
Add OWNERS for Experimental Framework

BUG=543141
==========

[chasej, 2015-11-02 16:32:45]

chasej@chromium.org changed reviewers:
+ esprehn@chromium.org, iclelland@chromium.org

[chasej, 2015-11-02 16:32:46]

esprehn, please take a look.

iclelland, please confirm as you are in the file.

[iclelland, 2015-11-02 17:02:37]

LGTM, but you might want to give jkarlin a chance to chime in as well, since
he's the one affected.

[iclelland, 2015-11-02 17:03:35]

On 2015/11/02 17:02:37, iclelland wrote:
> LGTM, but you might want to give jkarlin a chance to chime in as well, since
> he's the one affected.

Never mind, I just didn't read that the diff was from an entirely different
file.

LGTM without reservations, then :)

[esprehn, 2015-11-02 17:30:32]

I don't think we should be adding new files like this that aren't sunbsets of
core owners. 

Also especially given that you haven't landed any code, and dont have a history
of  contributing to blink.

Not lgtm.

Please try landing some patches to learn the ropes before making yourself an
owner.

[chasej, 2015-11-02 18:41:09]

On 2015/11/02 17:30:32, esprehn wrote:
> I don't think we should be adding new files like this that aren't sunbsets of
> core owners. 
> 
> Also especially given that you haven't landed any code, and dont have a
history
> of  contributing to blink.
> 
> Not lgtm.
> 
> Please try landing some patches to learn the ropes before making yourself an
> owner.

My intent was to add iclelland (Ian Clelland) as an owner (not myself).  Ian is
not an owner in core, but is already an owner for the background sync feature
(see CL 1417013003).  Ian and I are on the same team working on the Experimental
Framework.

From your first comment, is the guideline that a person should be an owner at
.../Source/core, if they are an owner in a subdirectory under core?  I see some
existing OWNERS files that don't seem to follow that approach (e.g. under
animation, editing).

[esprehn, 2015-11-03 00:35:59]

On 2015/11/02 at 18:41:09, chasej wrote:
> On 2015/11/02 17:30:32, esprehn wrote:
> > I don't think we should be adding new files like this that aren't sunbsets
of
> > core owners. 
> > 
> > Also especially given that you haven't landed any code, and dont have a
history
> > of  contributing to blink.
> > 
> > Not lgtm.
> > 
> > Please try landing some patches to learn the ropes before making yourself an
> > owner.
> 
> My intent was to add iclelland (Ian Clelland) as an owner (not myself).  Ian
is not an owner in core, but is already an owner for the background sync feature
(see CL 1417013003).  Ian and I are on the same team working on the Experimental
Framework.
> 
> From your first comment, is the guideline that a person should be an owner at
.../Source/core, if they are an owner in a subdirectory under core?  I see some
existing OWNERS files that don't seem to follow that approach (e.g. under
animation, editing).

That's different because it's in modules/ and not core/ where the rules are
somewhat relaxed.

[dglazkov, 2015-11-03 02:09:08]

Let's avoid these types of contraptions here. These CLs need to be reviewed by
peeps who are core owners.

[chasej, 2015-11-03 05:10:40]

On 2015/11/03 02:09:08, dglazkov wrote:
> Let's avoid these types of contraptions here. These CLs need to be reviewed by
> peeps who are core owners.

Noted, I'll close this CL.