Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412933005: Revert of Introduce WebMediaSession (Closed)

Created:
5 years, 2 months ago by davve
Modified:
5 years, 2 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce WebMediaSession (patchset #13 id:240001 of https://codereview.chromium.org/1370453002/ ) Reason for revert: Tests leak under address sanitizer. See https://code.google.com/p/chromium/issues/detail?id=546394. Original issue's description: > Introduce WebMediaSession > > WebMediaSession is the API enabling web exposed MediaSession objects > to control platform implementations of media session related > functionality. > > Implementation will begin with Android and other platforms will be > added later. > > BUG=497735 > > Committed: https://crrev.com/9b97db48d95635e9c5d48676df8dc51c9e5eef2a > Cr-Commit-Position: refs/heads/master@{#355058} TBR=jochen@chromium.org,avayvod@chromium.org,mlamouri@chromium.org,philipj@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497735 Committed: https://crrev.com/ddfc54f6422feb98d066cfdffd69175151724a5a Cr-Commit-Position: refs/heads/master@{#355503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -327 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/media/android/webmediasession_android.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/renderer/media/android/webmediasession_android.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/mediasession/media/mediasession/htmlmediaelement-set-session-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/mediasession/media/mediasession/mediasession-constructor-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/mediasession/media/mediasession/htmlmediaelement-set-session-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/mediasession/media/mediasession/mediasession-constructor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.h View 1 chunk +5 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 1 chunk +4 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.idl View 1 chunk +2 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/modules/mediasession/MediaSessionError.h View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/Source/modules/mediasession/MediaSessionError.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/modules/mediasession/MediaSessionTest.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/public/platform/modules/mediasession/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/modules/mediasession/WebMediaSession.h View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/public/platform/modules/mediasession/WebMediaSessionError.h View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davve
Created Revert of Introduce WebMediaSession
5 years, 2 months ago (2015-10-22 07:02:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412933005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412933005/1
5 years, 2 months ago (2015-10-22 07:02:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 07:02:58 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 07:03:50 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ddfc54f6422feb98d066cfdffd69175151724a5a
Cr-Commit-Position: refs/heads/master@{#355503}

Powered by Google App Engine
This is Rietveld 408576698