include fields in verify_deps, refactor graph dfs

bin/function_size_analysis.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Command-line tool presenting how much each function contributes to the total
 /// code.
 library compiler.tool.live_code_size_analysis;
 
 import 'dart:convert';
 import 'dart:io';
@@ skipping 13 matching lines @@
     {bool filter(Info info), bool showLibrarySizes: false}) {
   var realTotal = info.program.size;
   if (filter == null) filter = (i) => true;
   var reported = []
     ..addAll(info.functions.where(filter))
     ..addAll(info.fields.where(filter));
 
   // Compute a graph from the dependencies in [info].
   Graph<Info> graph = graphFromInfo(info);
 
-  // Compute the strongest connected components and calculate their size.
+  // Compute the strongly connected components and calculate their size.
   var components = graph.computeTopologicalSort();
   print('total elements: ${graph.nodes.length}');
-  print('total strongest connected components: ${components.length}');
+  print('total strongly connected components: ${components.length}');
   var maxS = 0;
   var totalCount = graph.nodeCount;
   var minS = totalCount;
   var nodeData = {};
   for (var scc in components) {
     var sccData = new _SccData();
     maxS = math.max(maxS, scc.length);
     minS = math.min(minS, scc.length);
     for (var f in scc) {
       sccData.size += f.size;
@@ skipping 109 matching lines @@
 
 _showElement(String name, int size, int dominatedSize, int maxSize, int total) {
   var percent = (size * 100 / total).toStringAsFixed(2);
   var minPercent = (dominatedSize * 100 / total).toStringAsFixed(2);
   var maxPercent = (maxSize * 100 / total).toStringAsFixed(2);
   print('${pad(size, 8)} ${pad(percent, 6)}% '
       '${pad(dominatedSize, 10)} ${pad(minPercent, 6)}% '
       '${pad(maxSize, 10)} ${pad(maxPercent, 6)}% '
       '$name');
 }