Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2452)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java

Issue 14129005: Remove "Use billing for shipping" checkbox in favor of item in suggestions menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java
index b0b1d0cae043789ef1c0b2aa311f4d1c54ec3c9f..268cd8c9f4b14cbdabc3daf5d60cfb2239173427 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java
@@ -154,8 +154,7 @@ public class AutofillDialog extends AlertDialog
public String getPlaceholderForField(int section, int fieldType);
}
- protected AutofillDialog(Context context, AutofillDialogDelegate delegate,
- String useBillingForShippingText) {
+ protected AutofillDialog(Context context, AutofillDialogDelegate delegate) {
super(context);
mDelegate = delegate;
@@ -167,9 +166,6 @@ public class AutofillDialog extends AlertDialog
mContentView = (AutofillDialogContentView) getLayoutInflater().
inflate(R.layout.autofill_dialog_content, null);
mContentView.setAutofillDialog(this);
- CheckBox useBillingCheck = getUseBillingForShippingCheckBox();
- useBillingCheck.setText(useBillingForShippingText);
- useBillingCheck.setChecked(true);
String[] labels = new String[AutofillDialogConstants.NUM_SECTIONS];
for (int i = 0; i < AutofillDialogConstants.NUM_SECTIONS; i++) {
labels[i] = mDelegate.getLabelForSection(i);
@@ -297,9 +293,6 @@ public class AutofillDialog extends AlertDialog
}
mDelegate.editingStart(section);
- if (section == AutofillDialogConstants.SECTION_SHIPPING) {
- getUseBillingForShippingCheckBox().setChecked(false);
- }
AutofillDialogMenuItem currentItem =
(AutofillDialogMenuItem) spinner.getItemAtPosition(position);
if (currentItem.mIndex == ADD_MENU_ITEM_INDEX) {
@@ -313,10 +306,6 @@ public class AutofillDialog extends AlertDialog
public void onNothingSelected(AdapterView<?> spinner) {
}
- private CheckBox getUseBillingForShippingCheckBox() {
- return (CheckBox) mContentView.findViewById(R.id.use_billing_checkbox);
- }
-
/**
* @param spinner The dropdown that was selected by the user.
* @param section The section that the dropdown corresponds to.
@@ -534,13 +523,6 @@ public class AutofillDialog extends AlertDialog
}
/**
- * @return Whether the billing address should be used as shipping address.
- */
- public boolean shouldUseBillingForShipping() {
- return getUseBillingForShippingCheckBox().isChecked();
- }
-
- /**
* @return Whether the details entered should be saved locally on the device.
*/
public boolean shouldSaveDetailsLocally() {

Powered by Google App Engine
This is Rietveld 408576698