Remove "Use billing for shipping" checkbox in favor of item in suggestions menu.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 77 matching lines @@
   void UpdateProgressBar(double value);
 
   // Called when there is an error in an active Autocheckout flow.
   void OnAutocheckoutError();
 
   // AutofillDialogController implementation.
   virtual string16 DialogTitle() const OVERRIDE;
   virtual string16 AccountChooserText() const OVERRIDE;
   virtual string16 SignInLinkText() const OVERRIDE;
   virtual string16 EditSuggestionText() const OVERRIDE;
-  virtual string16 UseBillingForShippingText() const OVERRIDE;
   virtual string16 CancelButtonText() const OVERRIDE;
   virtual string16 ConfirmButtonText() const OVERRIDE;
   virtual string16 SaveLocallyText() const OVERRIDE;
   virtual string16 CancelSignInText() const OVERRIDE;
   virtual string16 ProgressBarText() const OVERRIDE;
   virtual string16 LegalDocumentsText() OVERRIDE;
   virtual DialogSignedInState SignedInState() const OVERRIDE;
   virtual bool ShouldShowSpinner() const OVERRIDE;
   virtual bool ShouldOfferToSaveInChrome() const OVERRIDE;
   virtual ui::MenuModel* MenuModelForAccountChooser() OVERRIDE;
@@ skipping 49 matching lines @@
   virtual void RemoveSuggestion(const string16& value,
                                 int identifier) OVERRIDE;
   virtual void ClearPreviewedForm() OVERRIDE;
 
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // SuggestionsMenuModelDelegate implementation.
-  virtual void SuggestionItemSelected(const SuggestionsMenuModel& model)
-      OVERRIDE;
+  virtual void SuggestionItemSelected(SuggestionsMenuModel* model,
+                                      const std::string& item_key) OVERRIDE;
 
   // wallet::WalletClientDelegate implementation.
   virtual const AutofillMetrics& GetMetricLogger() const OVERRIDE;
   virtual DialogType GetDialogType() const OVERRIDE;
   virtual std::string GetRiskData() const OVERRIDE;
   virtual void OnDidAcceptLegalDocuments() OVERRIDE;
   virtual void OnDidAuthenticateInstrument(bool success) OVERRIDE;
   virtual void OnDidGetFullWallet(
       scoped_ptr<wallet::FullWallet> full_wallet) OVERRIDE;
   virtual void OnDidGetWalletItems(
@@ skipping 136 matching lines @@
       DialogSection section) const;
   // And the reverse.
   DialogSection SectionForSuggestionsMenuModel(
       const SuggestionsMenuModel& model);
 
   // Suggested text and icons for sections. Suggestion text is used to show an
   // abidged overview of the currently used suggestion. Extra text is used when
   // part of a section is suggested but part must be manually input (e.g. during
   // a CVC challenge or when using Autofill's CC section [never stores CVC]).
   string16 SuggestionTextForSection(DialogSection section);
+  gfx::Font::FontStyle SuggestionTextStyleForSection(DialogSection section)
+      const;

[Dan Beam, 2013/04/16 03:01:14]

opt. nit: I think there's something in the style guide about trying not to add
trailing `const`s on the next line, i.e. you'd wrap like:

  gfx::Font::FontStyle SuggestionTextStyleForSection(
      DialogSection section) const;

think I saw it fly past on a review... but can't procure evidence.

[Evan Stade, 2013/04/16 19:06:20]

that rule was removed from the style guide.

   string16 RequiredActionTextForSection(DialogSection section) const;
   gfx::Image SuggestionIconForSection(DialogSection section);
   string16 ExtraSuggestionTextForSection(DialogSection section) const;
   gfx::Image ExtraSuggestionIconForSection(DialogSection section) const;
 
   // Whether |section| should be showing an "Edit" link.
   bool EditEnabledForSection(DialogSection section) const;
 
   // Loads profiles that can suggest data for |type|. |field_contents| is the
   // part the user has already typed. |inputs| is the rest of section.
@@ skipping 26 matching lines @@
   bool IsManuallyEditingAnySection() const;
 
   // Whether all of the input fields currently showing in the dialog have valid
   // contents.
   bool AllSectionsAreValid() const;
 
   // Whether all of the input fields currently showing in the given |section| of
   // the dialog have valid contents.
   bool SectionIsValid(DialogSection section) const;
 
+  // Returns true if |key| refers to a suggestion, as opposed to some control
+  // menu item.
+  bool IsASuggestionItemKey(const std::string& key);
+
   // Whether the billing section should be used to fill in the shipping details.
   bool ShouldUseBillingForShipping();
 
   // Whether the user wishes to save information locally to Autofill.
   bool ShouldSaveDetailsLocally();
 
   // Change whether the controller is currently submitting details to Autofill
   // or Online Wallet (|is_submitting_|) and update the view.
   void SetIsSubmitting(bool submitting);
 
@@ skipping 145 matching lines @@
 
   // Whether or not there was an error in the Autocheckout flow.
   bool had_autocheckout_error_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_