Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2607)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java

Issue 14129003: Fix the incorrect native ImeAdapter attach and detach. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java
index 1f73502d70a17ff4705137121f602660c23553eb..507b8668bf5548b58ea757983441fe298d0c1ad1 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java
@@ -262,9 +262,11 @@ class ImeAdapter {
}
@CalledByNative
- void detach() {
- mNativeImeAdapterAndroid = 0;
- mTextInputType = 0;
+ void detach(int nativeImeAdapter) {
+ if (mNativeImeAdapterAndroid == nativeImeAdapter) {
aurimas (slooooooooow) 2013/04/11 05:51:56 Can you add a comment above here explaining why th
Shouqun Liu 2013/04/11 06:07:48 Done, a comment added. thanks for reviewing this
+ mNativeImeAdapterAndroid = 0;
+ mTextInputType = 0;
+ }
}
boolean hasInputType() {
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698