content/browser/renderer_host/ime_adapter_android.cc - Issue 14129003: Fix the incorrect native ImeAdapter attach and detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 14129003: Fix the incorrect native ImeAdapter attach and detach. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/ime_adapter_android.cc

diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc

index 3eab2b0958c22e477a35d66534de07da09e326f2..8c91b00da90c32d11fbab6a7be77c7cfbb2b051f 100644

--- a/content/browser/renderer_host/ime_adapter_android.cc

+++ b/content/browser/renderer_host/ime_adapter_android.cc

@@ -95,7 +95,7 @@ ImeAdapterAndroid::~ImeAdapterAndroid() {

JNIEnv* env = AttachCurrentThread();

base::android::ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);

if (!obj.is_null())

- Java_ImeAdapter_detach(env, obj.obj());

+ Java_ImeAdapter_detach(env, obj.obj(), reinterpret_cast<jint>(this));

}

bool ImeAdapterAndroid::SendSyntheticKeyEvent(JNIEnv*,