Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1412893007: Revert of [Turbofan] Fix perf regression (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Turbofan] Fix perf regression (patchset #1 id:1 of https://codereview.chromium.org/1412123009/ ) Reason for revert: [sheriff] breaks benchmarks: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/4998 Original issue's description: > [Turbofan] Fix perf regression introduced by per-range change. > > When the range ends just at the gap of a non-deferred block, the last > instruction the range covers is in the predecessor. If that predecessor is > a deferred block, before this CL, we would splinter the remainder of the > range all the way to the end. That leads to inefficient codegen, because > we still want a split inside the deferred block. > > Also, opportunistically added a trace before we splinter, for better > diagnostics. > > BUG=chromium:546416 > LOG=N > > Committed: https://crrev.com/32b6e085e74a8fcf94a01d20740fe4fdede07a86 > Cr-Commit-Position: refs/heads/master@{#31529} TBR=bmeurer@chromium.org,jarin@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:546416 Committed: https://crrev.com/5308a999eb3540c3ca19d4ba08d788a4970431e8 Cr-Commit-Position: refs/heads/master@{#31531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/compiler/live-range-separator.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [Turbofan] Fix perf regression
5 years, 2 months ago (2015-10-23 17:39:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412893007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412893007/1
5 years, 2 months ago (2015-10-23 17:40:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 17:40:10 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 17:40:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5308a999eb3540c3ca19d4ba08d788a4970431e8
Cr-Commit-Position: refs/heads/master@{#31531}

Powered by Google App Engine
This is Rietveld 408576698