Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1412893005: Revert of Use C++ implementation of Object.definePropert{y,ies} (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use C++ implementation of Object.definePropert{y,ies} (patchset #4 id:60001 of https://codereview.chromium.org/1409613004/ ) Reason for revert: [Sheriff] Breaks layout tests. Please request rebase upstream first if intended: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2427 One test times out now. Original issue's description: > Use C++ implementation of Object.definePropert{y,ies} > > For now, only rewire builtins in v8natives.js to call the new runtime functions. > > Committed: https://crrev.com/b2abc0e3ad4ce9dde8d66aab7aafae179e6948d4 > Cr-Commit-Position: refs/heads/master@{#31413} TBR=verwaest@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/581ead5c8ceeb0e4ee2049d78972418236f5d3ba Cr-Commit-Position: refs/heads/master@{#31424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -70 lines) Patch
M src/js/v8natives.js View 2 chunks +48 lines, -58 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/property-descriptor.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Use C++ implementation of Object.definePropert{y,ies}
5 years, 2 months ago (2015-10-20 19:49:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412893005/1
5 years, 2 months ago (2015-10-20 19:49:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 19:50:12 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 19:50:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/581ead5c8ceeb0e4ee2049d78972418236f5d3ba
Cr-Commit-Position: refs/heads/master@{#31424}

Powered by Google App Engine
This is Rietveld 408576698