Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1412893004: Rolling forward clang, hiding some warnings (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Added some untracked files which have been added by Chromium Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 921 matching lines...) Expand 10 before | Expand all | Expand 10 after
932 # which we no longer use. Check if it makes sense to remove 932 # which we no longer use. Check if it makes sense to remove
933 # this as well. http://crbug.com/316352 933 # this as well. http://crbug.com/316352
934 "-Wno-unneeded-internal-declaration", 934 "-Wno-unneeded-internal-declaration",
935 935
936 # TODO(thakis): Remove, http://crbug.com/263960 936 # TODO(thakis): Remove, http://crbug.com/263960
937 "-Wno-reserved-user-defined-literal", 937 "-Wno-reserved-user-defined-literal",
938 938
939 # TODO(hans): Get this cleaned up. 939 # TODO(hans): Get this cleaned up.
940 "-Wno-inconsistent-missing-override", 940 "-Wno-inconsistent-missing-override",
941 ] 941 ]
942
943 # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
944 # always have different versions. Certain flags may not be recognized by
945 # one version or the other.
946 if (!is_nacl) {
947 # Flags NaCl (Clang 3.7) does not recognize.
948 default_warning_flags += [
949 # TODO(smklein): Enable this, crbug.com/507717
950 "-Wno-shift-negative-value",
951
952 # TODO(smklein): Consider enabling this once not broken by third party
953 "-Wno-bitfield-width",
954 ]
955 }
942 } 956 }
943 957
944 # chromium_code --------------------------------------------------------------- 958 # chromium_code ---------------------------------------------------------------
945 # 959 #
946 # Toggles between higher and lower warnings for code that is (or isn't) 960 # Toggles between higher and lower warnings for code that is (or isn't)
947 # part of Chromium. 961 # part of Chromium.
948 962
949 config("chromium_code") { 963 config("chromium_code") {
950 if (is_win) { 964 if (is_win) {
951 cflags = [ "/W4" ] # Warning level 4. 965 cflags = [ "/W4" ] # Warning level 4.
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
999 "_CRT_NONSTDC_NO_WARNINGS", 1013 "_CRT_NONSTDC_NO_WARNINGS",
1000 "_CRT_NONSTDC_NO_DEPRECATE", 1014 "_CRT_NONSTDC_NO_DEPRECATE",
1001 ] 1015 ]
1002 } 1016 }
1003 1017
1004 if (is_linux) { 1018 if (is_linux) {
1005 # Don't warn about ignoring the return value from e.g. close(). This is 1019 # Don't warn about ignoring the return value from e.g. close(). This is
1006 # off by default in some gccs but on by default in others. BSD systems do 1020 # off by default in some gccs but on by default in others. BSD systems do
1007 # not support this option, since they are usually using gcc 4.2.1, which 1021 # not support this option, since they are usually using gcc 4.2.1, which
1008 # does not have this flag yet. 1022 # does not have this flag yet.
1009 cflags += [ "-Wno-unused-result" ] 1023 cflags += [
1024 "-Wno-logical-not-parentheses",
1025 "-Wno-unused-result",
1026 ]
1010 } 1027 }
1011 1028
1012 if (is_linux || is_android) { 1029 if (is_linux || is_android) {
1013 cflags += [ 1030 cflags += [
1014 # Don't warn about printf format problems. This is off by default in gcc 1031 # Don't warn about printf format problems. This is off by default in gcc
1015 # but on in Ubuntu's gcc(!). 1032 # but on in Ubuntu's gcc(!).
1016 "-Wno-format", 1033 "-Wno-format",
1017 ] 1034 ]
1018 cflags_cc += [ 1035 cflags_cc += [
1019 # Don't warn about hash_map in third-party code. 1036 # Don't warn about hash_map in third-party code.
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
1246 cflags += [ "-gsplit-dwarf" ] 1263 cflags += [ "-gsplit-dwarf" ]
1247 } 1264 }
1248 } 1265 }
1249 } 1266 }
1250 1267
1251 config("no_symbols") { 1268 config("no_symbols") {
1252 if (!is_win) { 1269 if (!is_win) {
1253 cflags = [ "-g0" ] 1270 cflags = [ "-g0" ]
1254 } 1271 }
1255 } 1272 }
OLDNEW
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698