Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: gpu/command_buffer/service/texture_manager.h

Issue 1412883002: Fix WebGL 2 texture renderability check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/texture_manager.h
diff --git a/gpu/command_buffer/service/texture_manager.h b/gpu/command_buffer/service/texture_manager.h
index a04cfa2a1f80315b209d05479f60b831d6402c82..2384112340afa36649ca394715e5ce784fcc9d5e 100644
--- a/gpu/command_buffer/service/texture_manager.h
+++ b/gpu/command_buffer/service/texture_manager.h
@@ -339,10 +339,11 @@ class GPU_EXPORT Texture {
GLenum format,
GLenum type);
- // Returns true if texture mip level is complete relative to first level.
- static bool TextureMipComplete(const Texture::LevelInfo& level0_face,
+ // Returns true if texture mip level is complete relative to base level.
+ // Note that level_diff = level - base_level.
+ static bool TextureMipComplete(const Texture::LevelInfo& base_level_face,
GLenum target,
- GLint level,
+ GLint level_diff,
GLenum internal_format,
GLsizei width,
GLsizei height,
@@ -402,6 +403,10 @@ class GPU_EXPORT Texture {
// referencing this texture.
void IncAllFramebufferStateChangeCount();
+ void UpdateBaseLevel(GLint base_level);
+ void UpdateMaxLevel(GLint max_level);
+ void UpdateNumMipLevels();
+
MailboxManager* mailbox_manager_;
// Info about each face and level of texture.

Powered by Google App Engine
This is Rietveld 408576698