Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1412863006: Fix some GPU filters to use the correct size constraint. (Closed)

Created:
5 years, 2 months ago by Stephen White
Modified:
5 years, 2 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix some GPU filters to use the correct size constraint. BUG=skia: Committed: https://skia.googlesource.com/skia/+/51eedb6e7db0de1d81128b727bfb9df60d77aa98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Stephen White
Some layout tests are not passing with the filterImage() CL, due to texture size mismatches. ...
5 years, 2 months ago (2015-10-23 16:20:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412863006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412863006/1
5 years, 2 months ago (2015-10-23 16:20:22 UTC) #5
reed1
lgtm Perhaps we should add these filters to the apply-filter GM. Clearly I didn't have ...
5 years, 2 months ago (2015-10-23 16:29:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-23 16:34:09 UTC) #9
Stephen White
Since we only really care about the assert, a unit test is probably best. See ...
5 years, 2 months ago (2015-10-23 16:56:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412863006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412863006/1
5 years, 2 months ago (2015-10-23 16:56:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/51eedb6e7db0de1d81128b727bfb9df60d77aa98
5 years, 2 months ago (2015-10-23 16:56:51 UTC) #13
reed1
5 years, 2 months ago (2015-10-23 17:31:08 UTC) #14
Message was sent while issue was closed.
On 2015/10/23 16:56:07, Stephen White wrote:
> Since we only really care about the assert, a unit test is probably best.
> See ImageFilterTest.cpp.

I agree a unittest should give sufficient coverage. However, ImageFilterTest.cpp
doesn't call appyFilter(), and that is the only code-path that would exercise
the asserts.

Powered by Google App Engine
This is Rietveld 408576698