components/arc/arc_pref_names.cc - Issue 1412863004: arc-bridge: Add the ARC Bridge Service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/arc_pref_names.cc

Issue 1412863004: arc-bridge: Add the ARC Bridge Service (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Added Pref names and separated file I/O to the correct thread Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/proxy_config/proxy_config_pref_names.h"	5 #include "components/arc/arc_pref_names.h"

6	6

7 namespace proxy_config {	7 namespace arc {

8 namespace prefs {	8 namespace prefs {

9	9

10 // Preference to store proxy settings.	10 // Whether using ARC is enabled.
	satorux1 2015/10/28 05:45:23 maybe drop 'using'? maybe drop 'using'? Luis Héctor Chávez 2015/10/28 17:19:14 Done. Show quoted text On 2015/10/28 05:45:23, satorux1 wrote: > maybe drop 'using'? Done.
11 const char kProxy[] = "proxy";	11 const char kArcEnabled[] =

	12 "arc.enabled";
	satorux1 2015/10/28 05:45:23 make it one line? make it one line? Luis Héctor Chávez 2015/10/28 17:19:15 Hmm I thought I had seen some other pref_names.cc Show quoted text On 2015/10/28 05:45:23, satorux1 wrote: > make it one line? Hmm I thought I had seen some other pref_names.cc files with very short lines split this way but I can't find the examples I looked at. Done.
12	13

13 } // namespace prefs	14 } // namespace prefs

14 } // namespace proxy_config	15 } // namespace arc

15

OLD	NEW