chrome/browser/ui/views/frame/opaque_browser_frame_view.h - Issue 1412833008: Draw the same portion of the frame background behind the tabstrip in maximized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.h

Issue 1412833008: Draw the same portion of the frame background behind the tabstrip in maximized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@match_frame_alignment

Patch Set: Add comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/glass_browser_frame_view.cc ('k') | chrome/browser/ui/views/frame/opaque_browser_frame_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.h

diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h b/chrome/browser/ui/views/frame/opaque_browser_frame_view.h

index e10548677cd53b3f197ca8f89dc491b0b411fbdf..83647be16008f669a020a9e66247b5923135dc2f 100644

--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h

+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.h

@@ -39,7 +39,7 @@ class OpaqueBrowserFrameView : public BrowserNonClientFrameView,

// BrowserNonClientFrameView:

gfx::Rect GetBoundsForTabStrip(views::View* tabstrip) const override;

- int GetTopInset() const override;

+ int GetTopInset(bool restored) const override;

int GetThemeBackgroundXInset() const override;

void UpdateThrobber(bool running) override;

gfx::Size GetMinimumSize() const override;

@@ -114,8 +114,8 @@ class OpaqueBrowserFrameView : public BrowserNonClientFrameView,

ViewID view_id);

// Returns the thickness of the border that makes up the window frame edges.

- // This does not include any client edge. If |restored| is true, acts as if

- // the window is restored regardless of the real mode.

+ // This does not include any client edge. If |restored| is true, this is

+ // calculated as if the window was restored, regardless of its current state.

int FrameBorderThickness(bool restored) const;

// Returns the height of the top resize area. This is smaller than the frame