chrome/browser/ui/views/frame/browser_view_unittest.cc - Issue 1412833008: Draw the same portion of the frame background behind the tabstrip in maximized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view_unittest.cc

Issue 1412833008: Draw the same portion of the frame background behind the tabstrip in maximized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@match_frame_alignment

Patch Set: Add comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout_unittest.cc ('k') | chrome/browser/ui/views/frame/glass_browser_frame_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view_unittest.cc

diff --git a/chrome/browser/ui/views/frame/browser_view_unittest.cc b/chrome/browser/ui/views/frame/browser_view_unittest.cc

index 23f3e7d5c3729d30845e642595e357f8177dc022..1d31c65acaf6556e982ed6458e1b0a10879245b1 100644

--- a/chrome/browser/ui/views/frame/browser_view_unittest.cc

+++ b/chrome/browser/ui/views/frame/browser_view_unittest.cc

@@ -193,7 +193,7 @@ TEST_F(BrowserViewHostedAppTest, Layout) {

// The position of the bottom of the header (the bar with the window

// controls) in the coordinates of BrowserView.

- int bottom_of_header = browser_view()->frame()->GetTopInset() -

+ int bottom_of_header = browser_view()->frame()->GetTopInset(false) -

header_offset.y();

// The web contents should be flush with the bottom of the header.

@@ -202,5 +202,5 @@ TEST_F(BrowserViewHostedAppTest, Layout) {

// The find bar should overlap the 1px header/web-contents separator at the

// bottom of the header.

EXPECT_LT(browser_view()->GetFindBarBoundingBox().y(),

- browser_view()->frame()->GetTopInset());

+ browser_view()->frame()->GetTopInset(false));

}