chrome/browser/ui/views/frame/browser_view.cc - Issue 1412833008: Draw the same portion of the frame background behind the tabstrip in maximized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1412833008: Draw the same portion of the frame background behind the tabstrip in maximized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@match_frame_alignment

Patch Set: Add comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc ('k') | chrome/browser/ui/views/frame/browser_view_layout.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index e6665e734e8b830210f85e2e6c2d8dd3b7ec4593..b9183f5e709b5551c57cd4d2df095c318fbf0d98 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -335,8 +335,8 @@ class BrowserViewLayoutDelegateImpl : public BrowserViewLayoutDelegate {

return gfx::ToEnclosingRect(bounds_f);

}

- int GetTopInsetInBrowserView() const override {

- return browser_view_->frame()->GetTopInset() -

+ int GetTopInsetInBrowserView(bool restored) const override {

+ return browser_view_->frame()->GetTopInset(restored) -

browser_view_->y();

}

@@ -594,7 +594,7 @@ gfx::Point BrowserView::OffsetPointForToolbarBackgroundImage(

// be). We expect our parent's origin to be the window origin.

gfx::Point window_point(point + GetMirroredPosition().OffsetFromOrigin());

window_point.Offset(frame_->GetThemeBackgroundXInset(),

- -frame_->GetTopInset());

+ -frame_->GetTopInset(false));

return window_point;

}