Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view_layout_unittest.cc

Issue 1412833008: Draw the same portion of the frame background behind the tabstrip in maximized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@match_frame_alignment
Patch Set: Add comment Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_view_layout.h" 5 #include "chrome/browser/ui/views/frame/browser_view_layout.h"
6 6
7 #include "chrome/browser/ui/views/frame/browser_view.h" 7 #include "chrome/browser/ui/views/frame/browser_view.h"
8 #include "chrome/browser/ui/views/frame/browser_view_layout_delegate.h" 8 #include "chrome/browser/ui/views/frame/browser_view_layout_delegate.h"
9 #include "chrome/browser/ui/views/frame/contents_layout_manager.h" 9 #include "chrome/browser/ui/views/frame/contents_layout_manager.h"
10 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h" 10 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
(...skipping 27 matching lines...) Expand all
38 } 38 }
39 39
40 // BrowserViewLayout::Delegate overrides: 40 // BrowserViewLayout::Delegate overrides:
41 views::View* GetContentsWebView() const override { 41 views::View* GetContentsWebView() const override {
42 return contents_web_view_; 42 return contents_web_view_;
43 } 43 }
44 bool IsTabStripVisible() const override { return tab_strip_visible_; } 44 bool IsTabStripVisible() const override { return tab_strip_visible_; }
45 gfx::Rect GetBoundsForTabStripInBrowserView() const override { 45 gfx::Rect GetBoundsForTabStripInBrowserView() const override {
46 return gfx::Rect(); 46 return gfx::Rect();
47 } 47 }
48 int GetTopInsetInBrowserView() const override { return 0; } 48 int GetTopInsetInBrowserView(bool restored) const override { return 0; }
49 int GetThemeBackgroundXInset() const override { return 0; } 49 int GetThemeBackgroundXInset() const override { return 0; }
50 bool IsToolbarVisible() const override { return toolbar_visible_; } 50 bool IsToolbarVisible() const override { return toolbar_visible_; }
51 bool IsBookmarkBarVisible() const override { return bookmark_bar_visible_; } 51 bool IsBookmarkBarVisible() const override { return bookmark_bar_visible_; }
52 bool DownloadShelfNeedsLayout() const override { 52 bool DownloadShelfNeedsLayout() const override {
53 return download_shelf_needs_layout_; 53 return download_shelf_needs_layout_;
54 } 54 }
55 55
56 ExclusiveAccessBubbleViews* GetExclusiveAccessBubble() const override { 56 ExclusiveAccessBubbleViews* GetExclusiveAccessBubble() const override {
57 return nullptr; 57 return nullptr;
58 } 58 }
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 const int kBottom = 500; 250 const int kBottom = 500;
251 EXPECT_EQ(kBottom, layout()->LayoutDownloadShelf(kBottom)); 251 EXPECT_EQ(kBottom, layout()->LayoutDownloadShelf(kBottom));
252 252
253 // Download shelf layout moves up the bottom edge and sets visibility. 253 // Download shelf layout moves up the bottom edge and sets visibility.
254 delegate()->set_download_shelf_needs_layout(true); 254 delegate()->set_download_shelf_needs_layout(true);
255 download_shelf->SetVisible(false); 255 download_shelf->SetVisible(false);
256 EXPECT_EQ(450, layout()->LayoutDownloadShelf(kBottom)); 256 EXPECT_EQ(450, layout()->LayoutDownloadShelf(kBottom));
257 EXPECT_TRUE(download_shelf->visible()); 257 EXPECT_TRUE(download_shelf->visible());
258 EXPECT_EQ("0,450 0x50", download_shelf->bounds().ToString()); 258 EXPECT_EQ("0,450 0x50", download_shelf->bounds().ToString());
259 } 259 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout_delegate.h ('k') | chrome/browser/ui/views/frame/browser_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698