Issue 141283007: roll gyp 1836:1840.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141283007: roll gyp 1836:1840. (Closed)

Created:
6 years, 11 months ago by Sébastien Marchand

Modified:
6 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

roll gyp 1836:1840. r1837: Support 'msvs_prebuild/msvs_postbuild' in MSBuild (VS 2010 and later) r1838: win ninja: build fix for msvs_pre/postbuild error test r1839: Fix VS 2008 generation with nested folders again r1840: Strip the invalid characters from the string used as mspdbsrv endpoint R=scottmg@chromium.org BUG=335607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245633

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/141283007/1

6 years, 11 months ago (2014-01-17 19:41:06 UTC) #3

Message was sent while issue was closed.

Change committed as 245633

Expand Messages | Collapse Messages