Issue 141283006: Remove stale 'virtual' in DiscardableMemoryAllocator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141283006: Remove stale 'virtual' in DiscardableMemoryAllocator. (Closed)

Created:
6 years, 11 months ago by Philippe

Modified:
6 years, 11 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove stale 'virtual' in DiscardableMemoryAllocator. DiscardableMemoryAllocator::AshmemRegion used to implement an interface but this is not the case anymore therefore there is no reason to keep ~AshmemRegion() virtual (since AshmemRegion is/should never be subclassed either). TBR=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245520

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/memory/discardable_memory_allocator_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/141283006/1

6 years, 11 months ago (2014-01-17 12:44:01 UTC) #1

Message was sent while issue was closed.

Change committed as 245520

Expand Messages | Collapse Messages