Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412823002: dart2js-dump-info: Explicitly pass architecture to test script like already done for build script. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
Cutch, srdjan
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-dump-info: Explicitly pass architecture to test script like already done for build script. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/14b7f9872f249964f48b06ed46d7f3345be00ef1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/bots/dart2js_dump_info.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-16 20:36:47 UTC) #2
Cutch
lgtm
5 years, 2 months ago (2015-10-16 20:37:59 UTC) #3
rmacnak
Committed patchset #1 (id:1) manually as 14b7f9872f249964f48b06ed46d7f3345be00ef1 (presubmit successful).
5 years, 2 months ago (2015-10-16 20:42:09 UTC) #4
srdjan
5 years, 2 months ago (2015-10-16 20:44:07 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698