Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Fix Win GN build. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
index 91f53821733c64f8912c57ba00d875ea599e5ee1..daed4a86b6dabd83dc961ba53845a835e22144a7 100644
--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
@@ -71,7 +71,9 @@ base::DictionaryValue* CreateUserInfo(const std::string& username,
user_dict->SetString("name", display_email);
user_dict->SetString("email", display_name);
- bool is_owner = user_manager::UserManager::Get()->GetOwnerEmail() == username;
+ const bool is_owner =
+ user_manager::UserManager::Get()->GetOwnerAccountId().GetUserEmail() ==
+ username;
user_dict->SetBoolean("owner", is_owner);
return user_dict;
}
@@ -89,7 +91,8 @@ base::Value* CreateUsersWhitelist(const base::Value *pref_value) {
std::string email;
if ((*i)->GetAsString(&email)) {
// Translate email to the display email.
- std::string display_email = user_manager->GetUserDisplayEmail(email);
+ const std::string display_email =
+ user_manager->GetUserDisplayEmail(AccountId::FromUserEmail(email));
// TODO(ivankr): fetch display name for existing users.
user_list->Append(CreateUserInfo(email, display_email, std::string()));
}
@@ -361,10 +364,12 @@ void CoreChromeOSOptionsHandler::GetLocalizedValues(
// Managed machines have no "owner".
localized_strings->SetString("controlledSettingOwner", base::string16());
} else {
- localized_strings->SetString("controlledSettingOwner",
+ localized_strings->SetString(
+ "controlledSettingOwner",
l10n_util::GetStringFUTF16(
IDS_OPTIONS_CONTROLLED_SETTING_OWNER,
- base::ASCIIToUTF16(user_manager->GetOwnerEmail())));
+ base::ASCIIToUTF16(
+ user_manager->GetOwnerAccountId().GetUserEmail())));
}
}

Powered by Google App Engine
This is Rietveld 408576698