Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4074)

Unified Diff: chrome/browser/signin/chrome_signin_client.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Fix Win GN build. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/chrome_signin_client.cc
diff --git a/chrome/browser/signin/chrome_signin_client.cc b/chrome/browser/signin/chrome_signin_client.cc
index 0247781b417681e3de6065bd6583fa06032b7d8c..ba280aa1d911d69baab3f5f0094864b39173467f 100644
--- a/chrome/browser/signin/chrome_signin_client.cc
+++ b/chrome/browser/signin/chrome_signin_client.cc
@@ -64,19 +64,19 @@ ChromeSigninClient::ChromeSigninClient(
if (!user)
return;
auto* user_manager = user_manager::UserManager::Get();
- const std::string& user_id = user->GetUserID();
- if (user_manager->GetKnownUserDeviceId(user_id).empty()) {
+ const AccountId account_id = user->GetAccountId();
+ if (user_manager->GetKnownUserDeviceId(account_id).empty()) {
const std::string legacy_device_id =
GetPrefs()->GetString(prefs::kGoogleServicesSigninScopedDeviceId);
if (!legacy_device_id.empty()) {
// Need to move device ID from the old location to the new one, if it has
// not been done yet.
- user_manager->SetKnownUserDeviceId(user_id, legacy_device_id);
+ user_manager->SetKnownUserDeviceId(account_id, legacy_device_id);
} else {
user_manager->SetKnownUserDeviceId(
- user_id,
+ account_id,
GenerateSigninScopedDeviceID(
- user_manager->IsUserNonCryptohomeDataEphemeral(user_id)));
+ user_manager->IsUserNonCryptohomeDataEphemeral(account_id)));
}
}
GetPrefs()->SetString(prefs::kGoogleServicesSigninScopedDeviceId,
@@ -154,7 +154,8 @@ std::string ChromeSigninClient::GetSigninScopedDeviceId() {
return std::string();
const std::string signin_scoped_device_id =
- user_manager::UserManager::Get()->GetKnownUserDeviceId(user->GetUserID());
+ user_manager::UserManager::Get()->GetKnownUserDeviceId(
+ user->GetAccountId());
LOG_IF(ERROR, signin_scoped_device_id.empty())
<< "Device ID is not set for user.";
return signin_scoped_device_id;

Powered by Google App Engine
This is Rietveld 408576698