Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/chromeos/login/kiosk_browsertest.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Fix Win GN build. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/kiosk_browsertest.cc
diff --git a/chrome/browser/chromeos/login/kiosk_browsertest.cc b/chrome/browser/chromeos/login/kiosk_browsertest.cc
index 7b80284b2d6b88235373cf8a905ab1877845fecf..f045f45b7bfdd7f89bce4e0d87633dba3c011e1c 100644
--- a/chrome/browser/chromeos/login/kiosk_browsertest.cc
+++ b/chrome/browser/chromeos/login/kiosk_browsertest.cc
@@ -451,7 +451,6 @@ class KioskTest : public OobeBaseTest {
public:
KioskTest()
: settings_helper_(false),
- use_consumer_kiosk_mode_(true),
fake_cws_(new FakeCWS) {
set_exit_when_last_browser_closes(false);
}
@@ -704,7 +703,7 @@ class KioskTest : public OobeBaseTest {
}
void RunAppLaunchNetworkDownTest() {
- mock_user_manager()->SetActiveUser(kTestOwnerEmail);
+ mock_user_manager()->SetActiveUser(test_owner_account_id_);
AppLaunchSigninScreen::SetUserManagerForTesting(mock_user_manager());
// Mock network could be configured with owner's password.
@@ -788,8 +787,11 @@ class KioskTest : public OobeBaseTest {
ScopedCrosSettingsTestHelper settings_helper_;
scoped_ptr<FakeOwnerSettingsService> owner_settings_service_;
+ const AccountId test_owner_account_id_ =
+ AccountId::FromUserEmail(kTestOwnerEmail);
+
private:
- bool use_consumer_kiosk_mode_;
+ bool use_consumer_kiosk_mode_ = true;
std::string test_app_id_;
std::string test_app_version_;
std::string test_crx_file_;
@@ -2017,7 +2019,7 @@ class KioskEnterpriseTest : public KioskTest {
void SetUpInProcessBrowserTestFixture() override {
policy::DevicePolicyCrosTestHelper::MarkAsEnterpriseOwnedBy(
- kTestOwnerEmail);
+ test_owner_account_id_.GetUserEmail());
settings_helper_.SetCurrentUserIsOwner(false);
KioskTest::SetUpInProcessBrowserTestFixture();
@@ -2228,7 +2230,7 @@ class KioskHiddenWebUITest : public KioskTest,
IN_PROC_BROWSER_TEST_F(KioskHiddenWebUITest, AutolaunchWarning) {
// Add a device owner.
FakeChromeUserManager* user_manager = new FakeChromeUserManager();
- user_manager->AddUser(kTestOwnerEmail);
+ user_manager->AddUser(test_owner_account_id_);
ScopedUserManagerEnabler enabler(user_manager);
// Set kiosk app to autolaunch.

Powered by Google App Engine
This is Rietveld 408576698