Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chromeos/login/auth/user_context.h

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Rebased. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/login/auth/user_context.h
diff --git a/chromeos/login/auth/user_context.h b/chromeos/login/auth/user_context.h
index 4dbd71b272a698111f1a76abf808937ff33599cf..f34960b9f93dd002d5b5f688ebfc3676876bcb18 100644
--- a/chromeos/login/auth/user_context.h
+++ b/chromeos/login/auth/user_context.h
@@ -9,8 +9,11 @@
#include "chromeos/chromeos_export.h"
#include "chromeos/login/auth/key.h"
+#include "components/signin/core/account_id/account_id.h"
#include "components/user_manager/user_type.h"
+class AccountId;
+
namespace chromeos {
// Information that is passed around while authentication is in progress. The
@@ -35,14 +38,14 @@ class CHROMEOS_EXPORT UserContext {
UserContext();
UserContext(const UserContext& other);
- explicit UserContext(const std::string& user_id);
+ explicit UserContext(const AccountId& user_id);
UserContext(user_manager::UserType user_type, const std::string& user_id);
~UserContext();
bool operator==(const UserContext& context) const;
bool operator!=(const UserContext& context) const;
- const std::string& GetUserID() const;
+ const AccountId& GetUserID() const;
achuithb 2015/10/23 00:08:52 I think this should be GetAccountID(). I know it's
Alexander Alekseev 2015/10/23 09:11:24 Done.
const std::string& GetGaiaID() const;
const Key* GetKey() const;
Key* GetKey();
@@ -78,7 +81,7 @@ class CHROMEOS_EXPORT UserContext {
void ClearSecrets();
private:
- std::string user_id_;
+ AccountId user_id_;
achuithb 2015/10/23 00:08:51 account_id_
Alexander Alekseev 2015/10/23 09:11:24 Done.
std::string gaia_id_;
Key key_;
std::string auth_code_;

Powered by Google App Engine
This is Rietveld 408576698