Chromium Code Reviews| Index: chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc |
| diff --git a/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc b/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc |
| index 9ec75fe5ead89ea4589271d7fc83de69c9d0da16..3c120a3fff7541e4d5e6772a7d76dabd4b67e61d 100644 |
| --- a/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc |
| +++ b/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc |
| @@ -86,8 +86,10 @@ const PrefTest kPrefTests[] = { |
| class SharedOptionsTest : public LoginManagerTest { |
| public: |
| SharedOptionsTest() |
| - : LoginManagerTest(false), |
| - device_settings_provider_(NULL) { |
| + : LoginManagerTest(false), |
| + device_settings_provider_(NULL), |
| + test_owner_id_(AccountId::FromUserEmail(kTestOwner)), |
| + test_non_owner_id_(AccountId::FromUserEmail(kTestNonOwner)) { |
| stub_settings_provider_.Set(kDeviceOwner, base::StringValue(kTestOwner)); |
| } |
| @@ -266,40 +268,43 @@ class SharedOptionsTest : public LoginManagerTest { |
| StubAccountSettingsProvider stub_settings_provider_; |
| CrosSettingsProvider* device_settings_provider_; |
| + const AccountId test_owner_id_; |
| + const AccountId test_non_owner_id_; |
| + |
| private: |
| DISALLOW_COPY_AND_ASSIGN(SharedOptionsTest); |
| }; |
| IN_PROC_BROWSER_TEST_F(SharedOptionsTest, PRE_SharedOptions) { |
| - RegisterUser(kTestOwner); |
| - RegisterUser(kTestNonOwner); |
| + RegisterUser(test_owner_id_.GetUserEmail()); |
| + RegisterUser(test_non_owner_id_.GetUserEmail()); |
|
stevenjb
2015/10/22 17:52:36
Would it be worth adding versions of LoginUser / A
Alexander Alekseev
2015/10/23 09:11:23
There are total 239 lines in 79 files referencing
|
| StartupUtils::MarkOobeCompleted(); |
| } |
| IN_PROC_BROWSER_TEST_F(SharedOptionsTest, SharedOptions) { |
| // Log in the owner first, then add a secondary user. |
| - LoginUser(kTestOwner); |
| + LoginUser(test_owner_id_.GetUserEmail()); |
| UserAddingScreen::Get()->Start(); |
| content::RunAllPendingInMessageLoop(); |
| - AddUser(kTestNonOwner); |
| + AddUser(test_non_owner_id_.GetUserEmail()); |
| user_manager::UserManager* manager = user_manager::UserManager::Get(); |
| ASSERT_EQ(2u, manager->GetLoggedInUsers().size()); |
| { |
| SCOPED_TRACE("Checking settings for owner, primary user."); |
| - CheckOptionsUI(manager->FindUser(manager->GetOwnerEmail()), true, true); |
| + CheckOptionsUI(manager->FindUser(manager->GetOwnerId()), true, true); |
| } |
| { |
| SCOPED_TRACE("Checking settings for non-owner, secondary user."); |
| - CheckOptionsUI(manager->FindUser(kTestNonOwner), false, false); |
| + CheckOptionsUI(manager->FindUser(test_non_owner_id_), false, false); |
| } |
| // TODO(michaelpg): Add tests for non-primary owner and primary non-owner |
| // when the owner-only multiprofile restriction is removed, probably M38. |
| } |
| IN_PROC_BROWSER_TEST_F(SharedOptionsTest, PRE_ScreenLockPreferencePrimary) { |
| - RegisterUser(kTestOwner); |
| - RegisterUser(kTestNonOwner); |
| + RegisterUser(test_owner_id_.GetUserEmail()); |
| + RegisterUser(test_non_owner_id_.GetUserEmail()); |
| StartupUtils::MarkOobeCompleted(); |
| } |
| @@ -309,14 +314,14 @@ IN_PROC_BROWSER_TEST_F(SharedOptionsTest, PRE_ScreenLockPreferencePrimary) { |
| // other signed-in user has enabled this preference, the shared setting |
| // indicator explains this.) |
| IN_PROC_BROWSER_TEST_F(SharedOptionsTest, ScreenLockPreferencePrimary) { |
| - LoginUser(kTestOwner); |
| + LoginUser(test_owner_id_.GetUserEmail()); |
| UserAddingScreen::Get()->Start(); |
| content::RunAllPendingInMessageLoop(); |
| - AddUser(kTestNonOwner); |
| + AddUser(test_non_owner_id_.GetUserEmail()); |
| user_manager::UserManager* manager = user_manager::UserManager::Get(); |
| - const user_manager::User* user1 = manager->FindUser(kTestOwner); |
| - const user_manager::User* user2 = manager->FindUser(kTestNonOwner); |
| + const user_manager::User* user1 = manager->FindUser(test_owner_id_); |
| + const user_manager::User* user2 = manager->FindUser(test_non_owner_id_); |
| PrefService* prefs1 = |
| ProfileHelper::Get()->GetProfileByUserUnsafe(user1)->GetPrefs(); |
| @@ -369,8 +374,8 @@ IN_PROC_BROWSER_TEST_F(SharedOptionsTest, ScreenLockPreferencePrimary) { |
| } |
| IN_PROC_BROWSER_TEST_F(SharedOptionsTest, PRE_ScreenLockPreferenceSecondary) { |
| - RegisterUser(kTestOwner); |
| - RegisterUser(kTestNonOwner); |
| + RegisterUser(test_owner_id_.GetUserEmail()); |
| + RegisterUser(test_non_owner_id_.GetUserEmail()); |
| StartupUtils::MarkOobeCompleted(); |
| } |
| @@ -380,14 +385,14 @@ IN_PROC_BROWSER_TEST_F(SharedOptionsTest, PRE_ScreenLockPreferenceSecondary) { |
| // other signed-in user has enabled this preference, the shared setting |
| // indicator explains this.) |
| IN_PROC_BROWSER_TEST_F(SharedOptionsTest, ScreenLockPreferenceSecondary) { |
| - LoginUser(kTestOwner); |
| + LoginUser(test_owner_id_.GetUserEmail()); |
| UserAddingScreen::Get()->Start(); |
| content::RunAllPendingInMessageLoop(); |
| - AddUser(kTestNonOwner); |
| + AddUser(test_non_owner_id_.GetUserEmail()); |
| user_manager::UserManager* manager = user_manager::UserManager::Get(); |
| - const user_manager::User* user1 = manager->FindUser(kTestOwner); |
| - const user_manager::User* user2 = manager->FindUser(kTestNonOwner); |
| + const user_manager::User* user1 = manager->FindUser(test_owner_id_); |
| + const user_manager::User* user2 = manager->FindUser(test_non_owner_id_); |
| PrefService* prefs1 = |
| ProfileHelper::Get()->GetProfileByUserUnsafe(user1)->GetPrefs(); |