Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3528)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Rebased. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index 1b3366588188fbf0175898a89c19e555eaeb0c81..9b6569cf6ae21a4dc4ae02e75e0d424d46471d74 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -989,7 +989,8 @@ void SigninScreenHandler::HandleAuthenticateUser(const std::string& username,
const std::string& password) {
if (!delegate_)
return;
- UserContext user_context(gaia::SanitizeEmail(username));
+ UserContext user_context(
+ AccountId::FromUserEmail(gaia::SanitizeEmail(username)));
user_context.SetKey(Key(password));
delegate_->Login(user_context, SigninSpecifics());
}
@@ -1073,7 +1074,7 @@ void SigninScreenHandler::HandleShowAddUser(const base::ListValue* args) {
args->GetString(0, &email);
gaia_screen_handler_->set_populated_email(email);
if (!email.empty())
- SendReauthReason(email);
+ SendReauthReason(AccountId::FromUserEmail(email));
OnShowAddUser();
}
@@ -1176,7 +1177,8 @@ void SigninScreenHandler::HandleLoginVisible(const std::string& source) {
void SigninScreenHandler::HandleCancelPasswordChangedFlow(
const std::string& user_id) {
if (!user_id.empty())
- RecordReauthReason(user_id, ReauthReason::PASSWORD_UPDATE_SKIPPED);
+ RecordReauthReason(AccountId::FromUserEmail(user_id),
+ ReauthReason::PASSWORD_UPDATE_SKIPPED);
gaia_screen_handler_->StartClearingCookies(
base::Bind(&SigninScreenHandler::CancelPasswordChangedFlowInternal,
weak_factory_.GetWeakPtr()));
@@ -1249,7 +1251,8 @@ void SigninScreenHandler::HandleFocusPod(const std::string& user_id) {
bool use_24hour_clock = false;
if (user_manager::UserManager::Get()->GetKnownUserBooleanPref(
- user_id, prefs::kUse24HourClock, &use_24hour_clock)) {
+ AccountId::FromUserEmail(user_id), prefs::kUse24HourClock,
+ &use_24hour_clock)) {
g_browser_process->platform_part()
->GetSystemClock()
->SetLastFocusedPodHourClockType(use_24hour_clock ? base::k24HourClock
@@ -1321,7 +1324,8 @@ void SigninScreenHandler::HandleFirstIncorrectPasswordAttempt(
void SigninScreenHandler::HandleMaxIncorrectPasswordAttempts(
const std::string& email) {
- RecordReauthReason(email, ReauthReason::INCORRECT_PASSWORD_ENTERED);
+ RecordReauthReason(AccountId::FromUserEmail(email),
+ ReauthReason::INCORRECT_PASSWORD_ENTERED);
}
bool SigninScreenHandler::AllWhitelistedUsersPresent() {
@@ -1342,7 +1346,8 @@ bool SigninScreenHandler::AllWhitelistedUsersPresent() {
std::string whitelisted_user;
// NB: Wildcards in the whitelist are also detected as not present here.
if (!whitelist->GetString(i, &whitelisted_user) ||
- !user_manager->IsKnownUser(whitelisted_user)) {
+ !user_manager->IsKnownUser(
+ AccountId::FromUserEmail(whitelisted_user))) {
return false;
}
}

Powered by Google App Engine
This is Rietveld 408576698