Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2587)

Unified Diff: chrome/browser/chromeos/login/users/fake_chrome_user_manager.h

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Rebased. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
diff --git a/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h b/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
index d5c90fcc26b13a1d99e59ecaa80d43ba4572edcd..f9a015d9f4f7a756f5450cdc7aae9be1d2ebbd0c 100644
--- a/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
+++ b/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
@@ -29,47 +29,45 @@ class FakeChromeUserManager : public user_manager::FakeUserManager,
~FakeChromeUserManager() override;
// Create and add a kiosk app user.
- void AddKioskAppUser(const std::string& kiosk_app_username);
+ void AddKioskAppUser(const AccountId& kiosk_app_user_id);
achuithb 2015/10/23 00:08:51 kiosk_app_account_id?
Alexander Alekseev 2015/10/23 09:11:23 Done.
// Create and add a public account user.
- const user_manager::User* AddPublicAccountUser(const std::string& email);
+ const user_manager::User* AddPublicAccountUser(const AccountId& user_id);
achuithb 2015/10/23 00:08:51 account_id?
Alexander Alekseev 2015/10/23 09:11:23 Done.
// Calculates the user name hash and calls UserLoggedIn to login a user.
- void LoginUser(const std::string& email);
+ void LoginUser(const AccountId& user_id);
// UserManager overrides.
user_manager::UserList GetUsersAllowedForMultiProfile() const override;
// user_manager::FakeUserManager override.
- const user_manager::User* AddUser(const std::string& email) override;
- const user_manager::User* AddUserWithAffiliation(const std::string& email,
+ const user_manager::User* AddUser(const AccountId& user_id) override;
+ const user_manager::User* AddUserWithAffiliation(const AccountId& user_id,
bool is_affiliated) override;
// UserManagerInterface implementation.
BootstrapManager* GetBootstrapManager() override;
MultiProfileUserController* GetMultiProfileUserController() override;
- UserImageManager* GetUserImageManager(const std::string& user_id) override;
+ UserImageManager* GetUserImageManager(const AccountId& user_id) override;
SupervisedUserManager* GetSupervisedUserManager() override;
- void SetUserFlow(const std::string& email, UserFlow* flow) override;
+ void SetUserFlow(const AccountId& user_id, UserFlow* flow) override;
UserFlow* GetCurrentUserFlow() const override;
- UserFlow* GetUserFlow(const std::string& email) const override;
- void ResetUserFlow(const std::string& email) override;
+ UserFlow* GetUserFlow(const AccountId& user_id) const override;
+ void ResetUserFlow(const AccountId& user_id) override;
user_manager::UserList GetUsersAllowedForSupervisedUsersCreation()
const override;
- void SwitchActiveUser(const std::string& email) override;
- const std::string& GetOwnerEmail() const override;
+ void SwitchActiveUser(const AccountId& user_id) override;
+ const AccountId& GetOwnerId() const override;
void SessionStarted() override;
- void RemoveUser(const std::string& email,
+ void RemoveUser(const AccountId& user_id,
user_manager::RemoveUserDelegate* delegate) override;
- bool FindKnownUserPrefs(const user_manager::UserID& user_id,
+ bool FindKnownUserPrefs(const AccountId& user_id,
const base::DictionaryValue** out_value) override;
- void UpdateKnownUserPrefs(const user_manager::UserID& user_id,
+ void UpdateKnownUserPrefs(const AccountId& user_id,
const base::DictionaryValue& values,
bool clear) override;
- void set_owner_email(const std::string& owner_email) {
- owner_email_ = owner_email;
- }
+ void set_owner_id(const AccountId& owner_id) { owner_id_ = owner_id; }
void set_bootstrap_manager(BootstrapManager* bootstrap_manager) {
bootstrap_manager_ = bootstrap_manager;
@@ -85,12 +83,12 @@ class FakeChromeUserManager : public user_manager::FakeUserManager,
UserFlow* GetDefaultUserFlow() const;
scoped_ptr<FakeSupervisedUserManager> supervised_user_manager_;
- std::string owner_email_;
+ AccountId owner_id_;
achuithb 2015/10/23 00:08:51 owner_account_id_?
Alexander Alekseev 2015/10/23 09:11:22 Done.
BootstrapManager* bootstrap_manager_;
MultiProfileUserController* multi_profile_user_controller_;
- typedef std::map<std::string, UserFlow*> FlowMap;
+ typedef std::map<AccountId, UserFlow*> FlowMap;
achuithb 2015/10/23 00:08:51 using FlowMap = std::map<AccountId, UserFlow*>;
Alexander Alekseev 2015/10/23 09:11:23 Done.
// Lazy-initialized default flow.
mutable scoped_ptr<UserFlow> default_flow_;

Powered by Google App Engine
This is Rietveld 408576698