Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5413)

Unified Diff: chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Rebased. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
diff --git a/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc b/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
index 7191f0c10b7bc0106f7e5bdc304d78bdae1ae85f..e38afbfdc57fe5a096c580e7e96311839039b7f3 100644
--- a/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
+++ b/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
@@ -19,25 +19,25 @@ class FakeSupervisedUserManager;
FakeChromeUserManager::FakeChromeUserManager()
: supervised_user_manager_(new FakeSupervisedUserManager),
+ owner_id_(EmptyAccountId()),
achuithb 2015/10/23 00:08:51 in class member initialization
Alexander Alekseev 2015/10/23 09:11:22 Done.
bootstrap_manager_(NULL),
- multi_profile_user_controller_(NULL) {
-}
+ multi_profile_user_controller_(NULL) {}
FakeChromeUserManager::~FakeChromeUserManager() {
}
const user_manager::User* FakeChromeUserManager::AddUser(
- const std::string& email) {
- return AddUserWithAffiliation(email, false);
+ const AccountId& account) {
achuithb 2015/10/23 00:08:51 account_id? here and below
Alexander Alekseev 2015/10/23 09:11:22 Done.
+ return AddUserWithAffiliation(account, false);
}
const user_manager::User* FakeChromeUserManager::AddUserWithAffiliation(
- const std::string& email,
+ const AccountId& account,
bool is_affiliated) {
- user_manager::User* user = user_manager::User::CreateRegularUser(email);
+ user_manager::User* user = user_manager::User::CreateRegularUser(account);
user->set_affiliation(is_affiliated);
user->set_username_hash(
- ProfileHelper::GetUserIdHashByUserIdForTesting(email));
+ ProfileHelper::GetUserIdHashByUserIdForTesting(account.GetUserEmail()));
user->SetStubImage(user_manager::UserImage(
*ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
IDR_PROFILE_PICTURE_LOADING)),
@@ -47,10 +47,11 @@ const user_manager::User* FakeChromeUserManager::AddUserWithAffiliation(
}
const user_manager::User* FakeChromeUserManager::AddPublicAccountUser(
- const std::string& email) {
- user_manager::User* user = user_manager::User::CreatePublicAccountUser(email);
+ const AccountId& account) {
+ user_manager::User* user =
+ user_manager::User::CreatePublicAccountUser(account);
user->set_username_hash(
- ProfileHelper::GetUserIdHashByUserIdForTesting(email));
+ ProfileHelper::GetUserIdHashByUserIdForTesting(account.GetUserEmail()));
user->SetStubImage(user_manager::UserImage(
*ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
IDR_PROFILE_PICTURE_LOADING)),
@@ -60,16 +61,17 @@ const user_manager::User* FakeChromeUserManager::AddPublicAccountUser(
}
void FakeChromeUserManager::AddKioskAppUser(
- const std::string& kiosk_app_username) {
+ const AccountId& kiosk_app_user_id) {
user_manager::User* user =
- user_manager::User::CreateKioskAppUser(kiosk_app_username);
- user->set_username_hash(
- ProfileHelper::GetUserIdHashByUserIdForTesting(kiosk_app_username));
+ user_manager::User::CreateKioskAppUser(kiosk_app_user_id);
+ user->set_username_hash(ProfileHelper::GetUserIdHashByUserIdForTesting(
+ kiosk_app_user_id.GetUserEmail()));
users_.push_back(user);
}
-void FakeChromeUserManager::LoginUser(const std::string& email) {
- UserLoggedIn(email, ProfileHelper::GetUserIdHashByUserIdForTesting(email),
+void FakeChromeUserManager::LoginUser(const AccountId& account) {
+ UserLoggedIn(account, ProfileHelper::GetUserIdHashByUserIdForTesting(
+ account.GetUserEmail()),
false /* browser_restart */);
}
@@ -87,58 +89,57 @@ SupervisedUserManager* FakeChromeUserManager::GetSupervisedUserManager() {
}
UserImageManager* FakeChromeUserManager::GetUserImageManager(
- const std::string& /* user_id */) {
+ const AccountId& /* user_id */) {
achuithb 2015/10/23 00:08:51 account_id
Alexander Alekseev 2015/10/23 09:11:22 Done.
return nullptr;
}
-void FakeChromeUserManager::SetUserFlow(const std::string& email,
+void FakeChromeUserManager::SetUserFlow(const AccountId& account,
UserFlow* flow) {
- ResetUserFlow(email);
- specific_flows_[email] = flow;
+ ResetUserFlow(account);
+ specific_flows_[account] = flow;
}
UserFlow* FakeChromeUserManager::GetCurrentUserFlow() const {
if (!IsUserLoggedIn())
return GetDefaultUserFlow();
- return GetUserFlow(GetLoggedInUser()->email());
+ return GetUserFlow(GetLoggedInUser()->GetUserID());
}
-UserFlow* FakeChromeUserManager::GetUserFlow(const std::string& email) const {
- FlowMap::const_iterator it = specific_flows_.find(email);
+UserFlow* FakeChromeUserManager::GetUserFlow(const AccountId& account) const {
+ FlowMap::const_iterator it = specific_flows_.find(account);
if (it != specific_flows_.end())
return it->second;
return GetDefaultUserFlow();
}
-void FakeChromeUserManager::ResetUserFlow(const std::string& email) {
- FlowMap::iterator it = specific_flows_.find(email);
+void FakeChromeUserManager::ResetUserFlow(const AccountId& account) {
+ FlowMap::iterator it = specific_flows_.find(account);
if (it != specific_flows_.end()) {
delete it->second;
specific_flows_.erase(it);
}
}
-void FakeChromeUserManager::SwitchActiveUser(const std::string& email) {
- active_user_id_ = email;
+void FakeChromeUserManager::SwitchActiveUser(const AccountId& account) {
+ active_user_id_ = account;
ProfileHelper::Get()->ActiveUserHashChanged(
- ProfileHelper::GetUserIdHashByUserIdForTesting(email));
+ ProfileHelper::GetUserIdHashByUserIdForTesting(account.GetUserEmail()));
if (!users_.empty() && !active_user_id_.empty()) {
for (user_manager::User* user : users_)
- user->set_is_active(user->email() == active_user_id_);
+ user->set_is_active(user->GetUserID() == active_user_id_);
}
}
-const std::string& FakeChromeUserManager::GetOwnerEmail() const {
- return owner_email_;
+const AccountId& FakeChromeUserManager::GetOwnerId() const {
+ return owner_id_;
}
void FakeChromeUserManager::SessionStarted() {
}
void FakeChromeUserManager::RemoveUser(
- const std::string& email,
- user_manager::RemoveUserDelegate* delegate) {
-}
+ const AccountId& account,
+ user_manager::RemoveUserDelegate* delegate) {}
user_manager::UserList
FakeChromeUserManager::GetUsersAllowedForSupervisedUsersCreation() const {
@@ -181,15 +182,14 @@ UserFlow* FakeChromeUserManager::GetDefaultUserFlow() const {
}
bool FakeChromeUserManager::FindKnownUserPrefs(
- const user_manager::UserID& user_id,
+ const AccountId& user_id,
const base::DictionaryValue** out_value) {
return false;
}
void FakeChromeUserManager::UpdateKnownUserPrefs(
- const user_manager::UserID& user_id,
+ const AccountId& user_id,
const base::DictionaryValue& values,
- bool clear) {
-}
+ bool clear) {}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698