This CL replaces user_manager::UserID with AccountId.

chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/users/chrome_user_manager_impl.h"
 
 #include <cstddef>
 #include <set>
 
 #include "ash/multi_profile_uma.h"
@@ skipping 188 matching lines @@
 BootstrapManager* ChromeUserManagerImpl::GetBootstrapManager() {
   return bootstrap_manager_.get();
 }
 
 MultiProfileUserController*
 ChromeUserManagerImpl::GetMultiProfileUserController() {
   return multi_profile_user_controller_.get();
 }
 
 UserImageManager* ChromeUserManagerImpl::GetUserImageManager(
-    const std::string& user_id) {
-  UserImageManagerMap::iterator ui = user_image_managers_.find(user_id);
+    const AccountId& account_id) {
+  UserImageManagerMap::iterator ui = user_image_managers_.find(account_id);
   if (ui != user_image_managers_.end())
     return ui->second.get();
-  linked_ptr<UserImageManagerImpl> mgr(new UserImageManagerImpl(user_id, this));
-  user_image_managers_[user_id] = mgr;
+  linked_ptr<UserImageManagerImpl> mgr(
+      new UserImageManagerImpl(account_id.GetUserEmail(), this));
+  user_image_managers_[account_id] = mgr;
   return mgr.get();
 }
 
 SupervisedUserManager* ChromeUserManagerImpl::GetSupervisedUserManager() {
   return supervised_user_manager_.get();
 }
 
 user_manager::UserList ChromeUserManagerImpl::GetUsersAllowedForMultiProfile()
     const {
   // Supervised users are not allowed to use multi-profiles.
@@ skipping 84 matching lines @@
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   ChromeUserManager::SessionStarted();
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_SESSION_STARTED,
       content::Source<UserManager>(this),
       content::Details<const user_manager::User>(GetActiveUser()));
 }
 
 void ChromeUserManagerImpl::RemoveUserInternal(
-    const std::string& user_email,
+    const AccountId& account_id,
     user_manager::RemoveUserDelegate* delegate) {
   CrosSettings* cros_settings = CrosSettings::Get();
 
   const base::Closure& callback =
       base::Bind(&ChromeUserManagerImpl::RemoveUserInternal,
-                 weak_factory_.GetWeakPtr(),
-                 user_email,
-                 delegate);
+                 weak_factory_.GetWeakPtr(), account_id, delegate);
 
   // Ensure the value of owner email has been fetched.
   if (CrosSettingsProvider::TRUSTED !=
       cros_settings->PrepareTrustedValues(callback)) {
     // Value of owner email is not fetched yet.  RemoveUserInternal will be
     // called again after fetch completion.
     return;
   }
   std::string owner;
   cros_settings->GetString(kDeviceOwner, &owner);
-  if (user_email == owner) {
+  if (account_id == AccountId::FromUserEmail(owner)) {

[achuithb, 2015/10/28 23:11:45]

This is changing to GaiaId, right?

[Alexander Alekseev, 2015/10/29 02:00:40]

Yes.
This is one of several serialization parts of code, where we would need to
replace it with gaiaid.

     // Owner is not allowed to be removed from the device.
     return;
   }
-  RemoveNonOwnerUserInternal(user_email, delegate);
+  RemoveNonOwnerUserInternal(account_id, delegate);
 }
 
 void ChromeUserManagerImpl::SaveUserOAuthStatus(
-    const std::string& user_id,
+    const AccountId& account_id,
     user_manager::User::OAuthTokenStatus oauth_token_status) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  ChromeUserManager::SaveUserOAuthStatus(user_id, oauth_token_status);
+  ChromeUserManager::SaveUserOAuthStatus(account_id, oauth_token_status);
 
-  GetUserFlow(user_id)->HandleOAuthTokenStatusChange(oauth_token_status);
+  GetUserFlow(account_id)->HandleOAuthTokenStatusChange(oauth_token_status);
 }
 
 void ChromeUserManagerImpl::SaveUserDisplayName(
-    const std::string& user_id,
+    const AccountId& account_id,
     const base::string16& display_name) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  ChromeUserManager::SaveUserDisplayName(user_id, display_name);
+  ChromeUserManager::SaveUserDisplayName(account_id, display_name);
 
   // Do not update local state if data stored or cached outside the user's
   // cryptohome is to be treated as ephemeral.
-  if (!IsUserNonCryptohomeDataEphemeral(user_id))
-    supervised_user_manager_->UpdateManagerName(user_id, display_name);
+  if (!IsUserNonCryptohomeDataEphemeral(account_id))

[achuithb, 2015/10/28 23:11:45]

I think use {} here because of the line break?

[Alexander Alekseev, 2015/10/29 02:00:40]

Done.

+    supervised_user_manager_->UpdateManagerName(account_id.GetUserEmail(),
+                                                display_name);
 }
 
 void ChromeUserManagerImpl::StopPolicyObserverForTesting() {
   avatar_policy_observer_.reset();
   wallpaper_policy_observer_.reset();
 }
 
 void ChromeUserManagerImpl::Observe(
     int type,
     const content::NotificationSource& source,
@@ skipping 31 matching lines @@
       break;
     }
     case chrome::NOTIFICATION_PROFILE_CREATED: {
       Profile* profile = content::Source<Profile>(source).ptr();
       user_manager::User* user =
           ProfileHelper::Get()->GetUserByProfile(profile);
       if (user != NULL) {
         user->set_profile_is_created();
 
         if (user->HasGaiaAccount()) {
-          UserImageManager* image_manager = GetUserImageManager(user->email());
+          UserImageManager* image_manager =
+              GetUserImageManager(user->GetAccountId());
           image_manager->UserProfileCreated();

[achuithb, 2015/10/28 23:11:45]

Maybe just:
GetUserImageManager(user->GetAccountId())->UserProfileCreated();

Might fit on one line.

[Alexander Alekseev, 2015/10/29 02:00:40]

Done.

         }
       }
 
       // If there is pending user switch, do it now.
-      if (!GetPendingUserSwitchID().empty()) {
+      if (GetPendingUserSwitchID().is_valid()) {
         // Call SwitchActiveUser async because otherwise it may cause
         // ProfileManager::GetProfile before the profile gets registered
         // in ProfileManager. It happens in case of sync profile load when
         // NOTIFICATION_PROFILE_CREATED is called synchronously.
         base::MessageLoop::current()->PostTask(
             FROM_HERE,
             base::Bind(&ChromeUserManagerImpl::SwitchActiveUser,
                        weak_factory_.GetWeakPtr(),
                        GetPendingUserSwitchID()));
-        SetPendingUserSwitchID(std::string());
+        SetPendingUserSwitchId(EmptyAccountId());
       }
       break;
     }
     default:
       NOTREACHED();
   }
 }
 
 void ChromeUserManagerImpl::OnExternalDataSet(const std::string& policy,
                                               const std::string& user_id) {
   if (policy == policy::key::kUserAvatarImage)
-    GetUserImageManager(user_id)->OnExternalDataSet(policy);
+    GetUserImageManager(AccountId::FromUserEmail(user_id))
+        ->OnExternalDataSet(policy);
   else if (policy == policy::key::kWallpaperImage)
     WallpaperManager::Get()->OnPolicySet(policy, user_id);
   else
     NOTREACHED();
 }
 
 void ChromeUserManagerImpl::OnExternalDataCleared(const std::string& policy,
                                                   const std::string& user_id) {
   if (policy == policy::key::kUserAvatarImage)
-    GetUserImageManager(user_id)->OnExternalDataCleared(policy);
+    GetUserImageManager(AccountId::FromUserEmail(user_id))
+        ->OnExternalDataCleared(policy);
   else if (policy == policy::key::kWallpaperImage)
     WallpaperManager::Get()->OnPolicyCleared(policy, user_id);
   else
     NOTREACHED();
 }
 
 void ChromeUserManagerImpl::OnExternalDataFetched(
     const std::string& policy,
     const std::string& user_id,
     scoped_ptr<std::string> data) {
   if (policy == policy::key::kUserAvatarImage)
-    GetUserImageManager(user_id)->OnExternalDataFetched(policy, data.Pass());
+    GetUserImageManager(AccountId::FromUserEmail(user_id))
+        ->OnExternalDataFetched(policy, data.Pass());
   else if (policy == policy::key::kWallpaperImage)
     WallpaperManager::Get()->OnPolicyFetched(policy, user_id, data.Pass());
   else
     NOTREACHED();
 }
 
 void ChromeUserManagerImpl::OnPolicyUpdated(const std::string& user_id) {
-  const user_manager::User* user = FindUser(user_id);
+  const user_manager::User* user = FindUser(AccountId::FromUserEmail(user_id));
   if (!user || user->GetType() != user_manager::USER_TYPE_PUBLIC_ACCOUNT)
     return;
   UpdatePublicAccountDisplayName(user_id);
 }
 
 void ChromeUserManagerImpl::OnDeviceLocalAccountsChanged() {
   // No action needed here, changes to the list of device-local accounts get
   // handled via the kAccountsPrefDeviceLocalAccounts device setting observer.
 }
 
 bool ChromeUserManagerImpl::CanCurrentUserLock() const {
   return ChromeUserManager::CanCurrentUserLock() &&
          GetCurrentUserFlow()->CanLockScreen();
 }
 
 bool ChromeUserManagerImpl::IsUserNonCryptohomeDataEphemeral(
-    const std::string& user_id) const {
+    const AccountId& account_id) const {
   // Data belonging to the obsolete public accounts whose data has not been
   // removed yet is not ephemeral.
-  bool is_obsolete_public_account = IsPublicAccountMarkedForRemoval(user_id);
+  bool is_obsolete_public_account = IsPublicAccountMarkedForRemoval(account_id);
 
   return !is_obsolete_public_account &&
-         ChromeUserManager::IsUserNonCryptohomeDataEphemeral(user_id);
+         ChromeUserManager::IsUserNonCryptohomeDataEphemeral(account_id);
 }
 
 bool ChromeUserManagerImpl::AreEphemeralUsersEnabled() const {
   policy::BrowserPolicyConnectorChromeOS* connector =
       g_browser_process->platform_part()->browser_policy_connector_chromeos();
   return GetEphemeralUsersEnabled() &&
-         (connector->IsEnterpriseManaged() || !GetOwnerEmail().empty());
+         (connector->IsEnterpriseManaged() || GetOwnerAccountId().is_valid());
 }
 
-void ChromeUserManagerImpl::OnUserRemoved(const std::string& user_id) {
-  RemoveReportingUser(FullyCanonicalize(user_id));
+void ChromeUserManagerImpl::OnUserRemoved(const AccountId& account_id) {
+  RemoveReportingUser(FullyCanonicalize(account_id.GetUserEmail()));
 }
 
 const std::string& ChromeUserManagerImpl::GetApplicationLocale() const {
   return g_browser_process->GetApplicationLocale();
 }
 
 PrefService* ChromeUserManagerImpl::GetLocalState() const {
   return g_browser_process ? g_browser_process->local_state() : NULL;
 }
 
 void ChromeUserManagerImpl::HandleUserOAuthTokenStatusChange(
-    const std::string& user_id,
+    const AccountId& account_id,
     user_manager::User::OAuthTokenStatus status) const {
-  GetUserFlow(user_id)->HandleOAuthTokenStatusChange(status);
+  GetUserFlow(account_id)->HandleOAuthTokenStatusChange(status);
 }
 
 bool ChromeUserManagerImpl::IsEnterpriseManaged() const {
   policy::BrowserPolicyConnectorChromeOS* connector =
       g_browser_process->platform_part()->browser_policy_connector_chromeos();
   return connector->IsEnterpriseManaged();
 }
 
 void ChromeUserManagerImpl::LoadPublicAccounts(
-    std::set<std::string>* public_sessions_set) {
+    std::set<AccountId>* public_sessions_set) {
   const base::ListValue* prefs_public_sessions =
       GetLocalState()->GetList(kPublicAccounts);
-  std::vector<std::string> public_sessions;
-  ParseUserList(*prefs_public_sessions,
-                std::set<std::string>(),
-                &public_sessions,
+  std::vector<AccountId> public_sessions;
+  ParseUserList(*prefs_public_sessions, std::set<AccountId>(), &public_sessions,
                 public_sessions_set);
-  for (std::vector<std::string>::const_iterator it = public_sessions.begin();
-       it != public_sessions.end();
-       ++it) {
-    users_.push_back(user_manager::User::CreatePublicAccountUser(*it));
-    UpdatePublicAccountDisplayName(*it);
+  for (const AccountId& account_id : public_sessions) {
+    users_.push_back(user_manager::User::CreatePublicAccountUser(account_id));
+    UpdatePublicAccountDisplayName(account_id.GetUserEmail());
   }
 }
 
 void ChromeUserManagerImpl::PerformPreUserListLoadingActions() {
   // Clean up user list first. All code down the path should be synchronous,
   // so that local state after transaction rollback is in consistent state.
   // This process also should not trigger EnsureUsersLoaded again.
   if (supervised_user_manager_->HasFailedUserCreationTransaction())
     supervised_user_manager_->RollbackUserCreationTransaction();
 
   // Abandon all unfinished bootstraps.
   bootstrap_manager_->RemoveAllPendingBootstrap();
 }
 
 void ChromeUserManagerImpl::PerformPostUserListLoadingActions() {
   for (user_manager::UserList::iterator ui = users_.begin(), ue = users_.end();
        ui != ue;
        ++ui) {
-    GetUserImageManager((*ui)->email())->LoadUserImage();
+    GetUserImageManager((*ui)->GetAccountId())->LoadUserImage();
   }
 }
 
 void ChromeUserManagerImpl::PerformPostUserLoggedInActions(
     bool browser_restart) {
   // Initialize the session length limiter and start it only if
   // session limit is defined by the policy.
   session_length_limiter_.reset(
       new SessionLengthLimiter(NULL, browser_restart));
 }
 
-bool ChromeUserManagerImpl::IsDemoApp(const std::string& user_id) const {
-  return DemoAppLauncher::IsDemoAppSession(user_id);
+bool ChromeUserManagerImpl::IsDemoApp(const AccountId& account_id) const {
+  return DemoAppLauncher::IsDemoAppSession(account_id.GetUserEmail());
 }
 
-bool ChromeUserManagerImpl::IsKioskApp(const std::string& user_id) const {
+bool ChromeUserManagerImpl::IsKioskApp(const AccountId& account_id) const {
   policy::DeviceLocalAccount::Type device_local_account_type;
-  return policy::IsDeviceLocalAccountUser(user_id,
+  return policy::IsDeviceLocalAccountUser(account_id.GetUserEmail(),
                                           &device_local_account_type) &&
          device_local_account_type ==
              policy::DeviceLocalAccount::TYPE_KIOSK_APP;
 }
 
 bool ChromeUserManagerImpl::IsPublicAccountMarkedForRemoval(
-    const std::string& user_id) const {
-  return user_id ==
-         GetLocalState()->GetString(kPublicAccountPendingDataRemoval);
+    const AccountId& account_id) const {
+  return account_id == AccountId::FromUserEmail(GetLocalState()->GetString(
+                           kPublicAccountPendingDataRemoval));
 }
 
 void ChromeUserManagerImpl::RetrieveTrustedDevicePolicies() {
   // Local state may not be initialized in unit_tests.
   if (!GetLocalState())
     return;
 
   SetEphemeralUsersEnabled(false);
-  SetOwnerEmail(std::string());
+  SetOwnerId(EmptyAccountId());
 
   // Schedule a callback if device policy has not yet been verified.
   if (CrosSettingsProvider::TRUSTED !=
       cros_settings_->PrepareTrustedValues(
           base::Bind(&ChromeUserManagerImpl::RetrieveTrustedDevicePolicies,
                      weak_factory_.GetWeakPtr()))) {
     return;
   }
 
   bool ephemeral_users_enabled = false;
   cros_settings_->GetBoolean(kAccountsPrefEphemeralUsersEnabled,
                              &ephemeral_users_enabled);
   SetEphemeralUsersEnabled(ephemeral_users_enabled);
 
   std::string owner_email;
   cros_settings_->GetString(kDeviceOwner, &owner_email);
-  SetOwnerEmail(owner_email);
+  SetOwnerId(AccountId::FromUserEmail(owner_email));
 
   EnsureUsersLoaded();
 
   bool changed = UpdateAndCleanUpPublicAccounts(
       policy::GetDeviceLocalAccounts(cros_settings_));
 
   // If ephemeral users are enabled and we are on the login screen, take this
   // opportunity to clean up by removing all regular users except the owner.
   if (GetEphemeralUsersEnabled() && !IsUserLoggedIn()) {
     ListPrefUpdate prefs_users_update(GetLocalState(), kRegularUsers);
     prefs_users_update->Clear();
     for (user_manager::UserList::iterator it = users_.begin();
          it != users_.end();) {
-      const std::string user_email = (*it)->email();
-      if ((*it)->HasGaiaAccount() && user_email != GetOwnerEmail()) {
-        RemoveNonCryptohomeData(user_email);
+      const AccountId account_id = (*it)->GetAccountId();
+      if ((*it)->HasGaiaAccount() && account_id != GetOwnerAccountId()) {
+        RemoveNonCryptohomeData(account_id);
         DeleteUser(*it);
         it = users_.erase(it);
         changed = true;
       } else {
         if ((*it)->GetType() != user_manager::USER_TYPE_PUBLIC_ACCOUNT)
-          prefs_users_update->Append(new base::StringValue(user_email));
+          prefs_users_update->Append(
+              new base::StringValue(account_id.GetUserEmail()));
         ++it;
       }
     }
   }
 
   if (changed)
     NotifyUserListChanged();
 }
 
 void ChromeUserManagerImpl::GuestUserLoggedIn() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   ChromeUserManager::GuestUserLoggedIn();
 
   // TODO(nkostylev): Add support for passing guest session cryptohome
   // mount point. Legacy (--login-profile) value will be used for now.
   // http://crosbug.com/230859
   active_user_->SetStubImage(
       user_manager::UserImage(
           *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
               IDR_PROFILE_PICTURE_LOADING)),
       user_manager::User::USER_IMAGE_INVALID,
       false);
 
   // Initializes wallpaper after active_user_ is set.
   WallpaperManager::Get()->SetUserWallpaperNow(chromeos::login::kGuestUserName);
 }
 
-void ChromeUserManagerImpl::RegularUserLoggedIn(const std::string& user_id) {
-  ChromeUserManager::RegularUserLoggedIn(user_id);
+void ChromeUserManagerImpl::RegularUserLoggedIn(const AccountId& account_id) {
+  ChromeUserManager::RegularUserLoggedIn(account_id);
 
   if (FakeOwnership()) {
-    std::string owner_email = GetActiveUser()->email();
-    VLOG(1) << "Set device owner to: " << owner_email;
-    CrosSettings::Get()->SetString(kDeviceOwner, owner_email);
-    SetOwnerEmail(owner_email);
+    const AccountId owner_id = GetActiveUser()->GetAccountId();

[achuithb, 2015/10/28 23:11:45]

owner_account_id?

[Alexander Alekseev, 2015/10/29 02:00:40]

Done.

+    VLOG(1) << "Set device owner to: " << owner_id.GetUserEmail();
+    CrosSettings::Get()->SetString(kDeviceOwner, owner_id.GetUserEmail());
+    SetOwnerId(owner_id);
   }
 
   if (IsCurrentUserNew())
-    WallpaperManager::Get()->SetUserWallpaperNow(user_id);
+    WallpaperManager::Get()->SetUserWallpaperNow(account_id.GetUserEmail());
 
-  GetUserImageManager(user_id)->UserLoggedIn(IsCurrentUserNew(), false);
+  GetUserImageManager(account_id)->UserLoggedIn(IsCurrentUserNew(), false);
 
   WallpaperManager::Get()->EnsureLoggedInUserWallpaperLoaded();
 
   // Make sure that new data is persisted to Local State.
   GetLocalState()->CommitPendingWrite();
 }
 
 void ChromeUserManagerImpl::RegularUserLoggedInAsEphemeral(
-    const std::string& user_id) {
+    const AccountId& account_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  ChromeUserManager::RegularUserLoggedInAsEphemeral(user_id);
+  ChromeUserManager::RegularUserLoggedInAsEphemeral(account_id);
 
-  GetUserImageManager(user_id)->UserLoggedIn(IsCurrentUserNew(), false);
-  WallpaperManager::Get()->SetUserWallpaperNow(user_id);
+  GetUserImageManager(account_id)->UserLoggedIn(IsCurrentUserNew(), false);
+  WallpaperManager::Get()->SetUserWallpaperNow(account_id.GetUserEmail());
 }
 
-void ChromeUserManagerImpl::SupervisedUserLoggedIn(const std::string& user_id) {
+void ChromeUserManagerImpl::SupervisedUserLoggedIn(
+    const AccountId& account_id) {
   // TODO(nkostylev): Refactor, share code with RegularUserLoggedIn().
 
   // Remove the user from the user list.
-  active_user_ = RemoveRegularOrSupervisedUserFromList(user_id);
+  active_user_ = RemoveRegularOrSupervisedUserFromList(account_id);
 
   // If the user was not found on the user list, create a new user.
   if (!GetActiveUser()) {
     SetIsCurrentUserNew(true);
-    active_user_ = user_manager::User::CreateSupervisedUser(user_id);
+    active_user_ = user_manager::User::CreateSupervisedUser(account_id);
     // Leaving OAuth token status at the default state = unknown.
-    WallpaperManager::Get()->SetUserWallpaperNow(user_id);
+    WallpaperManager::Get()->SetUserWallpaperNow(account_id.GetUserEmail());
   } else {
-    if (supervised_user_manager_->CheckForFirstRun(user_id)) {
+    if (supervised_user_manager_->CheckForFirstRun(account_id.GetUserEmail())) {
       SetIsCurrentUserNew(true);
-      WallpaperManager::Get()->SetUserWallpaperNow(user_id);
+      WallpaperManager::Get()->SetUserWallpaperNow(account_id.GetUserEmail());
     } else {
       SetIsCurrentUserNew(false);
     }
   }
 
   // Add the user to the front of the user list.
   ListPrefUpdate prefs_users_update(GetLocalState(), kRegularUsers);
-  prefs_users_update->Insert(0, new base::StringValue(user_id));
+  prefs_users_update->Insert(0,
+                             new base::StringValue(account_id.GetUserEmail()));
   users_.insert(users_.begin(), active_user_);
 
   // Now that user is in the list, save display name.
   if (IsCurrentUserNew()) {
-    SaveUserDisplayName(GetActiveUser()->email(),
+    SaveUserDisplayName(GetActiveUser()->GetAccountId(),
                         GetActiveUser()->GetDisplayName());
   }
 
-  GetUserImageManager(user_id)->UserLoggedIn(IsCurrentUserNew(), true);
+  GetUserImageManager(account_id)->UserLoggedIn(IsCurrentUserNew(), true);
   WallpaperManager::Get()->EnsureLoggedInUserWallpaperLoaded();
 
   // Make sure that new data is persisted to Local State.
   GetLocalState()->CommitPendingWrite();
 }
 
 bool ChromeUserManagerImpl::HasPendingBootstrap(
-    const std::string& user_id) const {
-  return bootstrap_manager_->HasPendingBootstrap(user_id);
+    const AccountId& account_id) const {
+  return bootstrap_manager_->HasPendingBootstrap(account_id.GetUserEmail());
 }
 
 void ChromeUserManagerImpl::PublicAccountUserLoggedIn(
     user_manager::User* user) {
   SetIsCurrentUserNew(true);
   active_user_ = user;
 
   // The UserImageManager chooses a random avatar picture when a user logs in
   // for the first time. Tell the UserImageManager that this user is not new to
   // prevent the avatar from getting changed.
-  GetUserImageManager(user->email())->UserLoggedIn(false, true);
+  GetUserImageManager(user->GetAccountId())->UserLoggedIn(false, true);
   WallpaperManager::Get()->EnsureLoggedInUserWallpaperLoaded();
 }
 
-void ChromeUserManagerImpl::KioskAppLoggedIn(const std::string& app_id) {
+void ChromeUserManagerImpl::KioskAppLoggedIn(
+    const AccountId& kiosk_app_account_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   policy::DeviceLocalAccount::Type device_local_account_type;
-  DCHECK(policy::IsDeviceLocalAccountUser(app_id, &device_local_account_type));
+  DCHECK(policy::IsDeviceLocalAccountUser(kiosk_app_account_id.GetUserEmail(),
+                                          &device_local_account_type));
   DCHECK_EQ(policy::DeviceLocalAccount::TYPE_KIOSK_APP,
             device_local_account_type);
 
-  active_user_ = user_manager::User::CreateKioskAppUser(app_id);
+  active_user_ = user_manager::User::CreateKioskAppUser(kiosk_app_account_id);
   active_user_->SetStubImage(
       user_manager::UserImage(
           *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
               IDR_PROFILE_PICTURE_LOADING)),
       user_manager::User::USER_IMAGE_INVALID,
       false);
 
-  WallpaperManager::Get()->SetUserWallpaperNow(app_id);
+  WallpaperManager::Get()->SetUserWallpaperNow(
+      kiosk_app_account_id.GetUserEmail());
 
   // TODO(bartfab): Add KioskAppUsers to the users_ list and keep metadata like
   // the kiosk_app_id in these objects, removing the need to re-parse the
   // device-local account list here to extract the kiosk_app_id.
   const std::vector<policy::DeviceLocalAccount> device_local_accounts =
       policy::GetDeviceLocalAccounts(cros_settings_);
   const policy::DeviceLocalAccount* account = NULL;
   for (std::vector<policy::DeviceLocalAccount>::const_iterator it =
            device_local_accounts.begin();
        it != device_local_accounts.end();
        ++it) {
-    if (it->user_id == app_id) {
+    if (it->user_id == kiosk_app_account_id.GetUserEmail()) {
       account = &*it;
       break;
     }
   }
-  std::string kiosk_app_id;
+  std::string kiosk_app_name;
   if (account) {
-    kiosk_app_id = account->kiosk_app_id;
+    kiosk_app_name = account->kiosk_app_id;
   } else {
-    LOG(ERROR) << "Logged into nonexistent kiosk-app account: " << app_id;
+    LOG(ERROR) << "Logged into nonexistent kiosk-app account: "
+               << kiosk_app_account_id.GetUserEmail();
     NOTREACHED();
   }
 
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   command_line->AppendSwitch(::switches::kForceAppMode);
-  command_line->AppendSwitchASCII(::switches::kAppId, kiosk_app_id);
+  command_line->AppendSwitchASCII(::switches::kAppId, kiosk_app_name);
 
   // Disable window animation since kiosk app runs in a single full screen
   // window and window animation causes start-up janks.
   command_line->AppendSwitch(wm::switches::kWindowAnimationsDisabled);
 }
 
 void ChromeUserManagerImpl::DemoAccountLoggedIn() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  active_user_ = user_manager::User::CreateKioskAppUser(
-      login::DemoAccountId().GetUserEmail());
+  active_user_ = user_manager::User::CreateKioskAppUser(login::DemoAccountId());
   active_user_->SetStubImage(
       user_manager::UserImage(
           *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
               IDR_PROFILE_PICTURE_LOADING)),
       user_manager::User::USER_IMAGE_INVALID,
       false);
   WallpaperManager::Get()->SetUserWallpaperNow(
       login::DemoAccountId().GetUserEmail());
 
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
@@ skipping 27 matching lines @@
 
 void ChromeUserManagerImpl::UpdateOwnership() {
   bool is_owner =
       FakeOwnership() || DeviceSettingsService::Get()->HasPrivateOwnerKey();
   VLOG(1) << "Current user " << (is_owner ? "is owner" : "is not owner");
 
   SetCurrentUserIsOwner(is_owner);
 }
 
 void ChromeUserManagerImpl::RemoveNonCryptohomeData(
-    const std::string& user_id) {
-  ChromeUserManager::RemoveNonCryptohomeData(user_id);
+    const AccountId& account_id) {
+  ChromeUserManager::RemoveNonCryptohomeData(account_id);
 
-  WallpaperManager::Get()->RemoveUserWallpaperInfo(user_id);
-  GetUserImageManager(user_id)->DeleteUserImage();
+  WallpaperManager::Get()->RemoveUserWallpaperInfo(account_id.GetUserEmail());
+  GetUserImageManager(account_id)->DeleteUserImage();
 
-  supervised_user_manager_->RemoveNonCryptohomeData(user_id);
+  supervised_user_manager_->RemoveNonCryptohomeData(account_id.GetUserEmail());
 
-  multi_profile_user_controller_->RemoveCachedValues(user_id);
+  multi_profile_user_controller_->RemoveCachedValues(account_id.GetUserEmail());
 
-  EasyUnlockService::ResetLocalStateForUser(user_id);
+  EasyUnlockService::ResetLocalStateForUser(account_id.GetUserEmail());
 }
 
 void
 ChromeUserManagerImpl::CleanUpPublicAccountNonCryptohomeDataPendingRemoval() {
   PrefService* local_state = GetLocalState();
   const std::string public_account_pending_data_removal =
       local_state->GetString(kPublicAccountPendingDataRemoval);
   if (public_account_pending_data_removal.empty() ||
       (IsUserLoggedIn() &&
        public_account_pending_data_removal == GetActiveUser()->email())) {
     return;
   }
 
-  RemoveNonCryptohomeData(public_account_pending_data_removal);
+  RemoveNonCryptohomeData(
+      AccountId::FromUserEmail(public_account_pending_data_removal));
   local_state->ClearPref(kPublicAccountPendingDataRemoval);
 }
 
 void ChromeUserManagerImpl::CleanUpPublicAccountNonCryptohomeData(
     const std::vector<std::string>& old_public_accounts) {
   std::set<std::string> users;
   for (user_manager::UserList::const_iterator it = users_.begin();
        it != users_.end();
        ++it)
     users.insert((*it)->email());
 
   // If the user is logged into a public account that has been removed from the
   // user list, mark the account's data as pending removal after logout.
   if (IsLoggedInAsPublicAccount()) {
     const std::string active_user_id = GetActiveUser()->email();
     if (users.find(active_user_id) == users.end()) {
       GetLocalState()->SetString(kPublicAccountPendingDataRemoval,
                                  active_user_id);
       users.insert(active_user_id);
     }
   }
 
   // Remove the data belonging to any other public accounts that are no longer
   // found on the user list.
   for (std::vector<std::string>::const_iterator it =
            old_public_accounts.begin();
        it != old_public_accounts.end();
        ++it) {
     if (users.find(*it) == users.end())
-      RemoveNonCryptohomeData(*it);
+      RemoveNonCryptohomeData(AccountId::FromUserEmail(*it));
   }
 }
 
 bool ChromeUserManagerImpl::UpdateAndCleanUpPublicAccounts(
     const std::vector<policy::DeviceLocalAccount>& device_local_accounts) {
   // Try to remove any public account data marked as pending removal.
   CleanUpPublicAccountNonCryptohomeDataPendingRemoval();
 
   // Get the current list of public accounts.
   std::vector<std::string> old_public_accounts;
@@ skipping 52 matching lines @@
   }
 
   // Add the new public accounts to the front of the user list.
   for (std::vector<std::string>::const_reverse_iterator it =
            new_public_accounts.rbegin();
        it != new_public_accounts.rend();
        ++it) {
     if (IsLoggedInAsPublicAccount() && *it == GetActiveUser()->email())
       users_.insert(users_.begin(), GetLoggedInUser());
     else
-      users_.insert(users_.begin(),
-                    user_manager::User::CreatePublicAccountUser(*it));
+      users_.insert(users_.begin(), user_manager::User::CreatePublicAccountUser(
+                                        AccountId::FromUserEmail(*it)));
     UpdatePublicAccountDisplayName(*it);
   }
 
   for (user_manager::UserList::iterator
            ui = users_.begin(),
            ue = users_.begin() + new_public_accounts.size();
        ui != ue;
        ++ui) {
-    GetUserImageManager((*ui)->email())->LoadUserImage();
+    GetUserImageManager((*ui)->GetAccountId())->LoadUserImage();
   }
 
   // Remove data belonging to public accounts that are no longer found on the
   // user list.
   CleanUpPublicAccountNonCryptohomeData(old_public_accounts);
 
   return true;
 }
 
 void ChromeUserManagerImpl::UpdatePublicAccountDisplayName(
     const std::string& user_id) {
   std::string display_name;
 
   if (device_local_account_policy_service_) {
     policy::DeviceLocalAccountPolicyBroker* broker =
         device_local_account_policy_service_->GetBrokerForUser(user_id);
     if (broker)
       display_name = broker->GetDisplayName();
   }
 
   // Set or clear the display name.
-  SaveUserDisplayName(user_id, base::UTF8ToUTF16(display_name));
+  SaveUserDisplayName(AccountId::FromUserEmail(user_id),
+                      base::UTF8ToUTF16(display_name));
 }
 
 UserFlow* ChromeUserManagerImpl::GetCurrentUserFlow() const {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   if (!IsUserLoggedIn())
     return GetDefaultUserFlow();
-  return GetUserFlow(GetLoggedInUser()->email());
+  return GetUserFlow(GetLoggedInUser()->GetAccountId());
 }
 
-UserFlow* ChromeUserManagerImpl::GetUserFlow(const std::string& user_id) const {
+UserFlow* ChromeUserManagerImpl::GetUserFlow(
+    const AccountId& account_id) const {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  FlowMap::const_iterator it = specific_flows_.find(user_id);
+  FlowMap::const_iterator it = specific_flows_.find(account_id);
   if (it != specific_flows_.end())
     return it->second;
   return GetDefaultUserFlow();
 }
 
-void ChromeUserManagerImpl::SetUserFlow(const std::string& user_id,
+void ChromeUserManagerImpl::SetUserFlow(const AccountId& account_id,
                                         UserFlow* flow) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  ResetUserFlow(user_id);
-  specific_flows_[user_id] = flow;
+  ResetUserFlow(account_id);
+  specific_flows_[account_id] = flow;
 }
 
-void ChromeUserManagerImpl::ResetUserFlow(const std::string& user_id) {
+void ChromeUserManagerImpl::ResetUserFlow(const AccountId& account_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  FlowMap::iterator it = specific_flows_.find(user_id);
+  FlowMap::iterator it = specific_flows_.find(account_id);
   if (it != specific_flows_.end()) {
     delete it->second;
     specific_flows_.erase(it);
   }
 }
 
 bool ChromeUserManagerImpl::AreSupervisedUsersAllowed() const {
   bool supervised_users_allowed = false;
   cros_settings_->GetBoolean(kAccountsPrefSupervisedUsersEnabled,
                              &supervised_users_allowed);
@@ skipping 15 matching lines @@
 }
 
 void ChromeUserManagerImpl::NotifyUserAddedToSession(
     const user_manager::User* added_user,
     bool user_switch_pending) {
   // Special case for user session restoration after browser crash.
   // We don't switch to each user session that has been restored as once all
   // session will be restored we'll switch to the session that has been used
   // before the crash.
   if (user_switch_pending &&
       !UserSessionManager::GetInstance()->UserSessionsRestoreInProgress()) {

[achuithb, 2015/10/28 23:11:45]

can probably drop {}

[Alexander Alekseev, 2015/10/29 02:00:40]

Here is a multiline condition. I don't think this will look good.

-    SetPendingUserSwitchID(added_user->email());
+    SetPendingUserSwitchId(added_user->GetAccountId());
   }
 
   UpdateNumberOfUsers();
   ChromeUserManager::NotifyUserAddedToSession(added_user, user_switch_pending);
 }
 
 void ChromeUserManagerImpl::OnUserNotAllowed(const std::string& user_email) {
   LOG(ERROR) << "Shutdown session because a user is not allowed to be in the "
                 "current session";
   chromeos::ShowMultiprofilesSessionAbortedDialog(user_email);
 }
 
 void ChromeUserManagerImpl::RemovePendingBootstrapUser(
     const std::string& user_id) {
-  DCHECK(HasPendingBootstrap(user_id));
-  RemoveNonOwnerUserInternal(user_id, NULL);
+  const AccountId account_id(AccountId::FromUserEmail(user_id));
+  DCHECK(HasPendingBootstrap(account_id));
+  RemoveNonOwnerUserInternal(account_id, nullptr);
 }
 
 void ChromeUserManagerImpl::UpdateNumberOfUsers() {
   size_t users = GetLoggedInUsers().size();
   if (users) {
     // Write the user number as UMA stat when a multi user session is possible.
     if ((users + GetUsersAllowedForMultiProfile().size()) > 1)
       ash::MultiProfileUMA::RecordUserCount(users);
   }
 
@@ skipping 33 matching lines @@
     g_browser_process->platform_part()->GetTimezoneResolver()->Start();
   } else {
     g_browser_process->platform_part()->GetTimezoneResolver()->Stop();
   }
 }
 
 void ChromeUserManagerImpl::SetUserAffiliation(
     const std::string& user_email,
     const AffiliationIDSet& user_affiliation_ids) {
   std::string canonicalized_email = FullyCanonicalize(user_email);
-  user_manager::User* user = FindUserAndModify(canonicalized_email);
+  user_manager::User* user =
+      FindUserAndModify(AccountId::FromUserEmail(canonicalized_email));
 
   if (user) {
     policy::BrowserPolicyConnectorChromeOS const* const connector =
         g_browser_process->platform_part()->browser_policy_connector_chromeos();
     const bool is_affiliated = chromeos::IsUserAffiliated(
         user_affiliation_ids, connector->GetDeviceAffiliationIDs(),
         canonicalized_email, connector->GetEnterpriseDomain());
     user->set_affiliation(is_affiliated);
 
     if (user->GetType() == user_manager::USER_TYPE_REGULAR) {
@@ skipping 18 matching lines @@
   users_update->AppendIfNotPresent(
       new base::StringValue(FullyCanonicalize(user_id)));
 }
 
 void ChromeUserManagerImpl::RemoveReportingUser(const std::string& user_id) {
   ListPrefUpdate users_update(GetLocalState(), kReportingUsers);
   users_update->Remove(base::StringValue(FullyCanonicalize(user_id)), NULL);
 }
 
 }  // namespace chromeos