Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: chrome/browser/chromeos/settings/device_settings_service_unittest.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Fix Win GN build. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/settings/device_settings_service.h" 5 #include "chrome/browser/chromeos/settings/device_settings_service.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 } 163 }
164 164
165 TEST_F(DeviceSettingsServiceTest, StoreSuccess) { 165 TEST_F(DeviceSettingsServiceTest, StoreSuccess) {
166 owner_key_util_->Clear(); 166 owner_key_util_->Clear();
167 device_settings_test_helper_.set_policy_blob(std::string()); 167 device_settings_test_helper_.set_policy_blob(std::string());
168 ReloadDeviceSettings(); 168 ReloadDeviceSettings();
169 EXPECT_EQ(DeviceSettingsService::STORE_KEY_UNAVAILABLE, 169 EXPECT_EQ(DeviceSettingsService::STORE_KEY_UNAVAILABLE,
170 device_settings_service_.status()); 170 device_settings_service_.status());
171 171
172 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 172 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
173 InitOwner(device_policy_.policy_data().username(), true); 173 InitOwner(AccountId::FromUserEmail(device_policy_.policy_data().username()),
174 true);
174 device_settings_service_.Store( 175 device_settings_service_.Store(
175 device_policy_.GetCopy(), 176 device_policy_.GetCopy(),
176 base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted, 177 base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted,
177 base::Unretained(this))); 178 base::Unretained(this)));
178 FlushDeviceSettings(); 179 FlushDeviceSettings();
179 EXPECT_TRUE(operation_completed_); 180 EXPECT_TRUE(operation_completed_);
180 EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS, 181 EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
181 device_settings_service_.status()); 182 device_settings_service_.status());
182 CheckPolicy(); 183 CheckPolicy();
183 } 184 }
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 237 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
237 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 238 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
238 std::vector<uint8> key; 239 std::vector<uint8> key;
239 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 240 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
240 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 241 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
241 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 242 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
242 device_settings_service_.GetOwnershipStatus()); 243 device_settings_service_.GetOwnershipStatus());
243 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_); 244 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_);
244 245
245 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey()); 246 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());
246 InitOwner(device_policy_.policy_data().username(), true); 247 InitOwner(AccountId::FromUserEmail(device_policy_.policy_data().username()),
248 true);
247 device_settings_service_.GetOwnershipStatusAsync( 249 device_settings_service_.GetOwnershipStatusAsync(
248 base::Bind(&DeviceSettingsServiceTest::SetOwnershipStatus, 250 base::Bind(&DeviceSettingsServiceTest::SetOwnershipStatus,
249 base::Unretained(this))); 251 base::Unretained(this)));
250 FlushDeviceSettings(); 252 FlushDeviceSettings();
251 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey()); 253 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());
252 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 254 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
253 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 255 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
254 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 256 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
255 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 257 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
256 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 258 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
257 device_settings_service_.GetOwnershipStatus()); 259 device_settings_service_.GetOwnershipStatus());
258 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_); 260 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_);
259 } 261 }
260 262
261 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForNonOwner) { 263 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForNonOwner) {
262 owner_key_util_->Clear(); 264 owner_key_util_->Clear();
263 265
264 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 266 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
265 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 267 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
266 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 268 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
267 device_settings_service_.GetOwnershipStatus()); 269 device_settings_service_.GetOwnershipStatus());
268 270
269 const std::string& user_id = device_policy_.policy_data().username(); 271 const std::string& user_id = device_policy_.policy_data().username();
270 InitOwner(user_id, false); 272 InitOwner(AccountId::FromUserEmail(user_id), false);
271 OwnerSettingsServiceChromeOS* service = 273 OwnerSettingsServiceChromeOS* service =
272 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 274 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get());
273 ASSERT_TRUE(service); 275 ASSERT_TRUE(service);
274 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner, 276 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner,
275 base::Unretained(this))); 277 base::Unretained(this)));
276 278
277 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 279 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
278 ReloadDeviceSettings(); 280 ReloadDeviceSettings();
279 281
280 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 282 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
(...skipping 24 matching lines...) Expand all
305 TEST_F(DeviceSettingsServiceTest, OwnerPrivateKeyInTPMToken) { 307 TEST_F(DeviceSettingsServiceTest, OwnerPrivateKeyInTPMToken) {
306 owner_key_util_->Clear(); 308 owner_key_util_->Clear();
307 309
308 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 310 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
309 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 311 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
310 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 312 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
311 device_settings_service_.GetOwnershipStatus()); 313 device_settings_service_.GetOwnershipStatus());
312 314
313 const std::string& user_id = device_policy_.policy_data().username(); 315 const std::string& user_id = device_policy_.policy_data().username();
314 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 316 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
315 InitOwner(user_id, false); 317 InitOwner(AccountId::FromUserEmail(user_id), false);
316 OwnerSettingsServiceChromeOS* service = 318 OwnerSettingsServiceChromeOS* service =
317 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 319 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get());
318 ASSERT_TRUE(service); 320 ASSERT_TRUE(service);
319 ReloadDeviceSettings(); 321 ReloadDeviceSettings();
320 322
321 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 323 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
322 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 324 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
323 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 325 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
324 std::vector<uint8> key; 326 std::vector<uint8> key;
325 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 327 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
(...skipping 15 matching lines...) Expand all
341 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForOwner) { 343 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForOwner) {
342 owner_key_util_->Clear(); 344 owner_key_util_->Clear();
343 345
344 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 346 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
345 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 347 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
346 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 348 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
347 device_settings_service_.GetOwnershipStatus()); 349 device_settings_service_.GetOwnershipStatus());
348 350
349 const std::string& user_id = device_policy_.policy_data().username(); 351 const std::string& user_id = device_policy_.policy_data().username();
350 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 352 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
351 InitOwner(user_id, false); 353 InitOwner(AccountId::FromUserEmail(user_id), false);
352 OwnerSettingsServiceChromeOS* service = 354 OwnerSettingsServiceChromeOS* service =
353 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 355 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get());
354 ASSERT_TRUE(service); 356 ASSERT_TRUE(service);
355 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner, 357 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner,
356 base::Unretained(this))); 358 base::Unretained(this)));
357 ReloadDeviceSettings(); 359 ReloadDeviceSettings();
358 360
359 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 361 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
360 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 362 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
361 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 363 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
(...skipping 23 matching lines...) Expand all
385 owner_key_util_->Clear(); 387 owner_key_util_->Clear();
386 388
387 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 389 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
388 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 390 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
389 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 391 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
390 device_settings_service_.GetOwnershipStatus()); 392 device_settings_service_.GetOwnershipStatus());
391 393
392 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 394 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
393 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey()); 395 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());
394 396
395 InitOwner(device_policy_.policy_data().username(), true); 397 InitOwner(AccountId::FromUserEmail(device_policy_.policy_data().username()),
398 true);
396 ReloadDeviceSettings(); 399 ReloadDeviceSettings();
397 FlushDeviceSettings(); 400 FlushDeviceSettings();
398 401
399 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey()); 402 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());
400 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 403 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
401 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 404 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
402 std::vector<uint8> key; 405 std::vector<uint8> key;
403 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 406 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
404 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 407 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
405 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 408 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
(...skipping 25 matching lines...) Expand all
431 device_settings_service_.AddObserver(&observer_); 434 device_settings_service_.AddObserver(&observer_);
432 435
433 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1); 436 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1);
434 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 437 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
435 ReloadDeviceSettings(); 438 ReloadDeviceSettings();
436 Mock::VerifyAndClearExpectations(&observer_); 439 Mock::VerifyAndClearExpectations(&observer_);
437 440
438 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1); 441 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1);
439 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 442 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
440 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 443 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
441 InitOwner(device_policy_.policy_data().username(), true); 444 InitOwner(AccountId::FromUserEmail(device_policy_.policy_data().username()),
445 true);
442 ReloadDeviceSettings(); 446 ReloadDeviceSettings();
443 Mock::VerifyAndClearExpectations(&observer_); 447 Mock::VerifyAndClearExpectations(&observer_);
444 448
445 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0); 449 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
446 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 450 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
447 device_settings_service_.Store(device_policy_.GetCopy(), base::Closure()); 451 device_settings_service_.Store(device_policy_.GetCopy(), base::Closure());
448 FlushDeviceSettings(); 452 FlushDeviceSettings();
449 Mock::VerifyAndClearExpectations(&observer_); 453 Mock::VerifyAndClearExpectations(&observer_);
450 454
451 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0); 455 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
452 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 456 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
453 device_settings_service_.PropertyChangeComplete(true); 457 device_settings_service_.PropertyChangeComplete(true);
454 FlushDeviceSettings(); 458 FlushDeviceSettings();
455 Mock::VerifyAndClearExpectations(&observer_); 459 Mock::VerifyAndClearExpectations(&observer_);
456 460
457 device_settings_service_.RemoveObserver(&observer_); 461 device_settings_service_.RemoveObserver(&observer_);
458 } 462 }
459 463
460 } // namespace chromeos 464 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698