Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: chrome/browser/chromeos/login/users/user_manager_unittest.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Fix Win GN build. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <cstdlib> 5 #include <cstdlib>
6 #include <cstring> 6 #include <cstring>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
(...skipping 29 matching lines...) Expand all
40 Profile* CreateProfileHelper(const base::FilePath& file_path) override { 40 Profile* CreateProfileHelper(const base::FilePath& file_path) override {
41 if (!base::PathExists(file_path)) { 41 if (!base::PathExists(file_path)) {
42 if (!base::CreateDirectory(file_path)) 42 if (!base::CreateDirectory(file_path))
43 return NULL; 43 return NULL;
44 } 44 }
45 return new TestingProfile(file_path, NULL); 45 return new TestingProfile(file_path, NULL);
46 } 46 }
47 }; 47 };
48 48
49 class UserManagerTest : public testing::Test { 49 class UserManagerTest : public testing::Test {
50 public:
51 UserManagerTest() {}
52
50 protected: 53 protected:
51 void SetUp() override { 54 void SetUp() override {
52 base::CommandLine& command_line = *base::CommandLine::ForCurrentProcess(); 55 base::CommandLine& command_line = *base::CommandLine::ForCurrentProcess();
53 command_line.AppendSwitch(::switches::kTestType); 56 command_line.AppendSwitch(::switches::kTestType);
54 command_line.AppendSwitch( 57 command_line.AppendSwitch(
55 chromeos::switches::kIgnoreUserProfileMappingForTests); 58 chromeos::switches::kIgnoreUserProfileMappingForTests);
56 59
57 settings_helper_.ReplaceProvider(kDeviceOwner); 60 settings_helper_.ReplaceProvider(kDeviceOwner);
58 61
59 // Populate the stub DeviceSettingsProvider with valid values. 62 // Populate the stub DeviceSettingsProvider with valid values.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 } 95 }
93 96
94 bool GetUserManagerEphemeralUsersEnabled() const { 97 bool GetUserManagerEphemeralUsersEnabled() const {
95 return GetChromeUserManager()->GetEphemeralUsersEnabled(); 98 return GetChromeUserManager()->GetEphemeralUsersEnabled();
96 } 99 }
97 100
98 void SetUserManagerEphemeralUsersEnabled(bool ephemeral_users_enabled) { 101 void SetUserManagerEphemeralUsersEnabled(bool ephemeral_users_enabled) {
99 GetChromeUserManager()->SetEphemeralUsersEnabled(ephemeral_users_enabled); 102 GetChromeUserManager()->SetEphemeralUsersEnabled(ephemeral_users_enabled);
100 } 103 }
101 104
102 const std::string& GetUserManagerOwnerEmail() const { 105 AccountId GetUserManagerOwnerId() const {
103 return GetChromeUserManager()->GetOwnerEmail(); 106 return GetChromeUserManager()->GetOwnerAccountId();
104 } 107 }
105 108
106 void SetUserManagerOwnerEmail(const std::string& owner_email) { 109 void SetUserManagerOwnerId(const AccountId& owner_account_id) {
107 GetChromeUserManager()->SetOwnerEmail(owner_email); 110 GetChromeUserManager()->SetOwnerId(owner_account_id);
108 } 111 }
109 112
110 void ResetUserManager() { 113 void ResetUserManager() {
111 // Reset the UserManager singleton. 114 // Reset the UserManager singleton.
112 user_manager_enabler_.reset(); 115 user_manager_enabler_.reset();
113 // Initialize the UserManager singleton to a fresh ChromeUserManagerImpl 116 // Initialize the UserManager singleton to a fresh ChromeUserManagerImpl
114 // instance. 117 // instance.
115 user_manager_enabler_.reset( 118 user_manager_enabler_.reset(
116 new ScopedUserManagerEnabler(new ChromeUserManagerImpl)); 119 new ScopedUserManagerEnabler(new ChromeUserManagerImpl));
117 120
118 // ChromeUserManagerImpl ctor posts a task to reload policies. 121 // ChromeUserManagerImpl ctor posts a task to reload policies.
119 base::RunLoop().RunUntilIdle(); 122 base::RunLoop().RunUntilIdle();
120 } 123 }
121 124
122 void SetDeviceSettings(bool ephemeral_users_enabled, 125 void SetDeviceSettings(bool ephemeral_users_enabled,
123 const std::string &owner, 126 const std::string &owner,
124 bool supervised_users_enabled) { 127 bool supervised_users_enabled) {
125 settings_helper_.SetBoolean(kAccountsPrefEphemeralUsersEnabled, 128 settings_helper_.SetBoolean(kAccountsPrefEphemeralUsersEnabled,
126 ephemeral_users_enabled); 129 ephemeral_users_enabled);
127 settings_helper_.SetString(kDeviceOwner, owner); 130 settings_helper_.SetString(kDeviceOwner, owner);
128 settings_helper_.SetBoolean(kAccountsPrefSupervisedUsersEnabled, 131 settings_helper_.SetBoolean(kAccountsPrefSupervisedUsersEnabled,
129 supervised_users_enabled); 132 supervised_users_enabled);
130 } 133 }
131 134
132 void RetrieveTrustedDevicePolicies() { 135 void RetrieveTrustedDevicePolicies() {
133 GetChromeUserManager()->RetrieveTrustedDevicePolicies(); 136 GetChromeUserManager()->RetrieveTrustedDevicePolicies();
134 } 137 }
135 138
139 const AccountId owner_account_id_at_invalid_domain_ =
140 AccountId::FromUserEmail("owner@invalid.domain");
141 const AccountId account_id0_at_invalid_domain_ =
142 AccountId::FromUserEmail("user0@invalid.domain");
143 const AccountId account_id1_at_invalid_domain_ =
144 AccountId::FromUserEmail("user1@invalid.domain");
145
136 protected: 146 protected:
137 content::TestBrowserThreadBundle thread_bundle_; 147 content::TestBrowserThreadBundle thread_bundle_;
138 148
139 ScopedCrosSettingsTestHelper settings_helper_; 149 ScopedCrosSettingsTestHelper settings_helper_;
140 scoped_ptr<ScopedTestingLocalState> local_state_; 150 scoped_ptr<ScopedTestingLocalState> local_state_;
141 151
142 scoped_ptr<ScopedUserManagerEnabler> user_manager_enabler_; 152 scoped_ptr<ScopedUserManagerEnabler> user_manager_enabler_;
143 base::ScopedTempDir temp_dir_; 153 base::ScopedTempDir temp_dir_;
144 }; 154 };
145 155
146 TEST_F(UserManagerTest, RetrieveTrustedDevicePolicies) { 156 TEST_F(UserManagerTest, RetrieveTrustedDevicePolicies) {
147 SetUserManagerEphemeralUsersEnabled(true); 157 SetUserManagerEphemeralUsersEnabled(true);
148 SetUserManagerOwnerEmail(""); 158 SetUserManagerOwnerId(EmptyAccountId());
149 159
150 SetDeviceSettings(false, "owner@invalid.domain", false); 160 SetDeviceSettings(false, owner_account_id_at_invalid_domain_.GetUserEmail(),
161 false);
151 RetrieveTrustedDevicePolicies(); 162 RetrieveTrustedDevicePolicies();
152 163
153 EXPECT_FALSE(GetUserManagerEphemeralUsersEnabled()); 164 EXPECT_FALSE(GetUserManagerEphemeralUsersEnabled());
154 EXPECT_EQ(GetUserManagerOwnerEmail(), "owner@invalid.domain"); 165 EXPECT_EQ(GetUserManagerOwnerId(), owner_account_id_at_invalid_domain_);
155 } 166 }
156 167
157 TEST_F(UserManagerTest, RemoveAllExceptOwnerFromList) { 168 TEST_F(UserManagerTest, RemoveAllExceptOwnerFromList) {
158 user_manager::UserManager::Get()->UserLoggedIn( 169 user_manager::UserManager::Get()->UserLoggedIn(
159 "owner@invalid.domain", "owner@invalid.domain", false); 170 owner_account_id_at_invalid_domain_,
171 owner_account_id_at_invalid_domain_.GetUserEmail(), false);
160 ResetUserManager(); 172 ResetUserManager();
161 user_manager::UserManager::Get()->UserLoggedIn( 173 user_manager::UserManager::Get()->UserLoggedIn(
162 "user0@invalid.domain", "owner@invalid.domain", false); 174 account_id0_at_invalid_domain_,
175 owner_account_id_at_invalid_domain_.GetUserEmail(), false);
163 ResetUserManager(); 176 ResetUserManager();
164 user_manager::UserManager::Get()->UserLoggedIn( 177 user_manager::UserManager::Get()->UserLoggedIn(
165 "user1@invalid.domain", "owner@invalid.domain", false); 178 account_id1_at_invalid_domain_,
179 owner_account_id_at_invalid_domain_.GetUserEmail(), false);
166 ResetUserManager(); 180 ResetUserManager();
167 181
168 const user_manager::UserList* users = 182 const user_manager::UserList* users =
169 &user_manager::UserManager::Get()->GetUsers(); 183 &user_manager::UserManager::Get()->GetUsers();
170 ASSERT_EQ(3U, users->size()); 184 ASSERT_EQ(3U, users->size());
171 EXPECT_EQ((*users)[0]->email(), "user1@invalid.domain"); 185 EXPECT_EQ((*users)[0]->GetAccountId(), account_id1_at_invalid_domain_);
172 EXPECT_EQ((*users)[1]->email(), "user0@invalid.domain"); 186 EXPECT_EQ((*users)[1]->GetAccountId(), account_id0_at_invalid_domain_);
173 EXPECT_EQ((*users)[2]->email(), "owner@invalid.domain"); 187 EXPECT_EQ((*users)[2]->GetAccountId(), owner_account_id_at_invalid_domain_);
174 188
175 SetDeviceSettings(true, "owner@invalid.domain", false); 189 SetDeviceSettings(true, owner_account_id_at_invalid_domain_.GetUserEmail(),
190 false);
176 RetrieveTrustedDevicePolicies(); 191 RetrieveTrustedDevicePolicies();
177 192
178 users = &user_manager::UserManager::Get()->GetUsers(); 193 users = &user_manager::UserManager::Get()->GetUsers();
179 EXPECT_EQ(1U, users->size()); 194 EXPECT_EQ(1U, users->size());
180 EXPECT_EQ((*users)[0]->email(), "owner@invalid.domain"); 195 EXPECT_EQ((*users)[0]->GetAccountId(), owner_account_id_at_invalid_domain_);
181 } 196 }
182 197
183 TEST_F(UserManagerTest, RegularUserLoggedInAsEphemeral) { 198 TEST_F(UserManagerTest, RegularUserLoggedInAsEphemeral) {
184 SetDeviceSettings(true, "owner@invalid.domain", false); 199 SetDeviceSettings(true, owner_account_id_at_invalid_domain_.GetUserEmail(),
200 false);
185 RetrieveTrustedDevicePolicies(); 201 RetrieveTrustedDevicePolicies();
186 202
187 user_manager::UserManager::Get()->UserLoggedIn( 203 user_manager::UserManager::Get()->UserLoggedIn(
188 "owner@invalid.domain", "user0@invalid.domain", false); 204 owner_account_id_at_invalid_domain_,
205 account_id0_at_invalid_domain_.GetUserEmail(), false);
189 ResetUserManager(); 206 ResetUserManager();
190 user_manager::UserManager::Get()->UserLoggedIn( 207 user_manager::UserManager::Get()->UserLoggedIn(
191 "user0@invalid.domain", "user0@invalid.domain", false); 208 account_id0_at_invalid_domain_,
209 account_id0_at_invalid_domain_.GetUserEmail(), false);
192 ResetUserManager(); 210 ResetUserManager();
193 211
194 const user_manager::UserList* users = 212 const user_manager::UserList* users =
195 &user_manager::UserManager::Get()->GetUsers(); 213 &user_manager::UserManager::Get()->GetUsers();
196 EXPECT_EQ(1U, users->size()); 214 EXPECT_EQ(1U, users->size());
197 EXPECT_EQ((*users)[0]->email(), "owner@invalid.domain"); 215 EXPECT_EQ((*users)[0]->GetAccountId(), owner_account_id_at_invalid_domain_);
198 } 216 }
199 217
200 } // namespace chromeos 218 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698