Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Side by Side Diff: chrome/browser/chromeos/login/reauth_stats.h

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Rebased. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_REAUTH_STATS_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_REAUTH_STATS_H_
6 #define CHROME_BROWSER_CHROMEOS_LOGIN_REAUTH_STATS_H_ 6 #define CHROME_BROWSER_CHROMEOS_LOGIN_REAUTH_STATS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 class AccountId;
11
10 namespace chromeos { 12 namespace chromeos {
11 13
12 // Track all the ways a user may be sent through the re-auth flow. 14 // Track all the ways a user may be sent through the re-auth flow.
13 // This enum is used to define the buckets for an enumerated UMA histogram. 15 // This enum is used to define the buckets for an enumerated UMA histogram.
14 // Hence, existing enumerated constants should never be reordered, and all new 16 // Hence, existing enumerated constants should never be reordered, and all new
15 // constants should only be appended at the end of the enumeration. 17 // constants should only be appended at the end of the enumeration.
16 enum ReauthReason { 18 enum ReauthReason {
17 // Default value: no reauth reasons were detected so far, or the reason was 19 // Default value: no reauth reasons were detected so far, or the reason was
18 // already reported. 20 // already reported.
19 NONE = 0, 21 NONE = 0,
(...skipping 24 matching lines...) Expand all
44 // etc. 46 // etc.
45 SYNC_FAILED = 7, 47 SYNC_FAILED = 7,
46 48
47 // User cancelled the password change prompt when prompted by Chrome OS. 49 // User cancelled the password change prompt when prompted by Chrome OS.
48 PASSWORD_UPDATE_SKIPPED = 8, 50 PASSWORD_UPDATE_SKIPPED = 8,
49 51
50 // Must be the last value in this list. 52 // Must be the last value in this list.
51 NUM_REAUTH_FLOW_REASONS, 53 NUM_REAUTH_FLOW_REASONS,
52 }; 54 };
53 55
54 void RecordReauthReason(const std::string& user_id, ReauthReason reason); 56 void RecordReauthReason(const AccountId& user_id, ReauthReason reason);
achuithb 2015/10/23 00:08:50 account_id here and below
Alexander Alekseev 2015/10/23 09:11:21 Done.
55 void SendReauthReason(const std::string& user_id); 57 void SendReauthReason(const AccountId& user_id);
56 58
57 } // namespace chromeos 59 } // namespace chromeos
58 60
59 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_REAUTH_STATS_H_ 61 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_REAUTH_STATS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698