Change quality settings on SkImageDecoder_libjpeg

tools/valgrind.supp

Index: tools/valgrind.supp
diff --git a/tools/valgrind.supp b/tools/valgrind.supp
index ffb71089f903408d81f5b47143267509b46c78de..47d44240ca082d27f3e2aad69fb541a2acd57c27 100644
--- a/tools/valgrind.supp
+++ b/tools/valgrind.supp
@@ -236,3 +236,76 @@
     Memcheck:Addr2
     fun:_ZN22GrAAConvexPathRenderer10onDrawPathERK6SkPathRK11SkStrokeRecP12GrDrawTargetb
 }
+{
+    libjpeg_turbo_bug4550_1
+    Memcheck:Cond
+    fun:_Z26S32A_Opaque_BlitRow32_SSE4PjPKjij
+    fun:_ZN14Sprite_D32_S328blitRectEiiii
+    fun:_ZN6SkScan9FillIRectERK7SkIRectPK8SkRegionP9SkBlitter
+    fun:_ZN6SkScan9FillIRectERK7SkIRectRK12SkRasterClipP9SkBlitter
+    fun:_ZNK6SkDraw10drawBitmapERK8SkBitmapRK8SkMatrixPK6SkRectRK7SkPaint
+    fun:_ZN14SkBitmapDevice10drawBitmapERK6SkDrawRK8SkBitmapRK8SkMatrixRK7SkPaint
+    fun:_ZN12SkBaseDevice9drawImageERK6SkDrawPK7SkImageffRK7SkPaint
+    fun:_ZN8SkCanvas11onDrawImageEPK7SkImageffPK7SkPaint
+    fun:_ZN8SkCanvas9drawImageEPK7SkImageffPK7SkPaint
+    fun:_ZN8SKPBench19onPerCanvasPostDrawEP8SkCanvas
+    fun:_ZN9Benchmark17perCanvasPostDrawEP8SkCanvas
+    fun:_Z14nanobench_mainv
+    fun:main
+}
+{
+    libjpeg_turbo_bug4550_2

[scroggo, 2015/11/10 21:24:40]

Does valgrind need us to include every single line here? It seems like the stack
resulting in this draw could change, making the suppression ineffective

[msarett, 2015/11/10 21:34:13]

We don't need this much detail to suppress the errors.

It was actually intentional to make these suppressions very specific.  Because
they make me a little nervous.  There are no references to libjpeg-turbo in the
stack trace, just to drawing code.  I'd hate to suppress actual errors in our
drawing code because libjpeg-turbo has a problem.

Of course, you also make a good point.  However, if the stack trace does change,
it may give us a nice reminder to fix these :).

+    Memcheck:Cond
+    fun:_ZL15S32A_D565_BlendPtPKjijii
+    fun:_ZN26Sprite_D16_S32_BlitRowProc8blitRectEiiii
+    fun:_ZN6SkScan9FillIRectERK7SkIRectPK8SkRegionP9SkBlitter
+    fun:_ZN6SkScan9FillIRectERK7SkIRectRK12SkRasterClipP9SkBlitter
+    fun:_ZNK6SkDraw10drawSpriteERK8SkBitmapiiRK7SkPaint
+    fun:_ZN14SkBitmapDevice10drawDeviceERK6SkDrawP12SkBaseDeviceiiRK7SkPaint
+    fun:_ZN8SkCanvas18internalDrawDeviceEP12SkBaseDeviceiiPK7SkPaintb
+    fun:_ZN8SkCanvas15internalRestoreEv
+    fun:_ZN8SkCanvas7restoreEv
+    fun:_Z12SkRecordDrawRK8SkRecordP8SkCanvasPKPK9SkPicturePKP10SkDrawableiPK15SkBBoxHierarchyPNS4_13AbortCallbackE
+    fun:_ZNK12SkBigPicture8playbackEP8SkCanvasPN9SkPicture13AbortCallbackE
+    fun:_ZN8SkCanvas13onDrawPictureEPK9SkPicturePK8SkMatrixPK7SkPaint
+    fun:_ZN8SkCanvas11drawPictureEPK9SkPicturePK8SkMatrixPK7SkPaint
+    fun:_ZN9SkRecords4Draw4drawINS_11DrawPictureEEEvRKT_
+    fun:_Z12SkRecordDrawRK8SkRecordP8SkCanvasPKPK9SkPicturePKP10SkDrawableiPK15SkBBoxHierarchyPNS4_13AbortCallbackE
+    fun:_ZNK12SkBigPicture8playbackEP8SkCanvasPN9SkPicture13AbortCallbackE
+    fun:_ZN8SkCanvas13onDrawPictureEPK9SkPicturePK8SkMatrixPK7SkPaint
+    fun:_ZN8SkCanvas11drawPictureEPK9SkPicturePK8SkMatrixPK7SkPaint
+    fun:_ZN18SkMultiPictureDraw8DrawData4drawEv
+    fun:_ZZ15sk_parallel_forIZN18SkMultiPictureDraw4drawEbEUliE_EviRKT_ENUlPZS_IS1_EviS4_E5ChunkE_4_FUNES6_
+    fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
+    fun:_ZL12thread_startPv
+    fun:start_thread
+    fun:clone
+}
+{
+    libjpeg_turbo_bug4550_3
+    Memcheck:Cond
+    fun:_ZN12_GLOBAL__N_120ConvolveHorizontallyILb0EEEvPKhRK21SkConvolutionFilter1DPh
+    fun:_Z14BGRAConvolve2DPKhibRK21SkConvolutionFilter1DS3_iPhRK18SkConvolutionProcsb
+    fun:_ZN14SkBitmapScaler6ResizeEP8SkBitmapRK8SkPixmapNS_12ResizeMethodEiiPNS0_9AllocatorE
+    fun:_ZN30SkDefaultBitmapControllerState16processHQRequestERK16SkBitmapProvider
+    fun:_ZN30SkDefaultBitmapControllerStateC1ERK16SkBitmapProviderRK8SkMatrix15SkFilterQuality
+    fun:_ZN25SkDefaultBitmapController15onRequestBitmapERK16SkBitmapProviderRK8SkMatrix15SkFilterQualityPvm
+    fun:_ZN18SkBitmapController13requestBitmapERK16SkBitmapProviderRK8SkMatrix15SkFilterQualityPvm
+    fun:_ZN17SkBitmapProcState11chooseProcsERK8SkMatrixRK7SkPaint
+    fun:_ZN18SkBitmapProcShader11MakeContextERK8SkShaderNS0_8TileModeES3_RK16SkBitmapProviderRKNS0_10ContextRecEPv
+    fun:_ZNK18SkBitmapProcShader15onCreateContextERKN8SkShader10ContextRecEPv
+    fun:_ZNK8SkShader13createContextERKNS_10ContextRecEPv
+    fun:_ZN9SkBlitter6ChooseERK8SkPixmapRK8SkMatrixRK7SkPaintP16SkSmallAllocatorILj3ELm1160EEb
+    fun:_ZNK6SkDraw8drawRectERK6SkRectRK7SkPaintPK8SkMatrixPS1_
+    fun:_ZNK6SkDraw10drawBitmapERK8SkBitmapRK8SkMatrixPK6SkRectRK7SkPaint
+    fun:_ZN14SkBitmapDevice14drawBitmapRectERK6SkDrawRK8SkBitmapPK6SkRectRS7_RK7SkPaintN8SkCanvas17SrcRectConstraintE
+    fun:_ZN12SkBaseDevice13drawImageRectERK6SkDrawPK7SkImagePK6SkRectRS7_RK7SkPaintN8SkCanvas17SrcRectConstraintE
+    fun:_ZN8SkCanvas15onDrawImageRectEPK7SkImagePK6SkRectRS4_PK7SkPaintNS_17SrcRectConstraintE
+    fun:_ZN8SkCanvas13drawImageRectEPK7SkImageRK6SkRectS5_PK7SkPaintNS_17SrcRectConstraintE
+    fun:_ZN8SkCanvas20legacy_drawImageRectEPK7SkImagePK6SkRectRS4_PK7SkPaintNS_17SrcRectConstraintE
+    fun:_ZN9SkRecords4Draw4drawINS_13DrawImageRectEEEvRKT_
+    fun:_Z12SkRecordDrawRK8SkRecordP8SkCanvasPKPK9SkPicturePKP10SkDrawableiPK15SkBBoxHierarchyPNS4_13AbortCallbackE
+    fun:_ZNK12SkBigPicture8playbackEP8SkCanvasPN9SkPicture13AbortCallbackE
+    fun:_ZN8SkCanvas13onDrawPictureEPK9SkPicturePK8SkMatrixPK7SkPaint
+    fun:_ZN8SkCanvas11drawPictureEPK9SkPicturePK8SkMatrixPK7SkPaint
+}