third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 1412803007: Parse text-decoration shorthand in CSSPropertyParser with CSSParserTokens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1412803007: Parse text-decoration shorthand in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Alternative fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-line-expected.html ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index bffd19cb3739757faada6b2283a4eb33c66c1967..384d1e7753c324c1c74ce942be69b857f3635734 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -114,6 +114,7 @@ private:

bool parseShorthand(CSSPropertyID, const StylePropertyShorthand&, bool important);

bool parseShorthand(CSSPropertyID, bool important);

+ bool consumeShorthand(CSSPropertyID, const StylePropertyShorthand&, bool important);

bool parse4Values(CSSPropertyID, const CSSPropertyID* properties, bool important);

PassRefPtrWillBeRawPtr<CSSValueList> parseContent();

@@ -241,8 +242,6 @@ private:

PassRefPtrWillBeRawPtr<CSSValue> parseTextEmphasisStyle();

- PassRefPtrWillBeRawPtr<CSSValue> parseTextDecoration();

bool parseCalculation(CSSParserValue*, ValueRange);

bool parseGeneratedImage(CSSParserValueList*, RefPtrWillBeRawPtr<CSSValue>&);