Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: chrome/chrome_dll.gypi

Issue 1412803002: Switch Chrome to dlopen() the Google Chrome Framework.framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a shim so that Chrome does not link chrome_dll Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_dll.gypi
diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi
index b0422e4f6669a27b0763f7f14542a7dc3c23e568..b2a2081929c6bff4aadbc4a51d6fa80037ecc3fb 100644
--- a/chrome/chrome_dll.gypi
+++ b/chrome/chrome_dll.gypi
@@ -3,6 +3,35 @@
# found in the LICENSE file.
{
'conditions': [
+ # Dummy target to allow chrome to require chrome_dll to build
+ # without actually linking to the library
+ ['OS=="mac"', {
+ 'targets': [
+ {
+ 'target_name': 'chrome_dll_dependency_shim',
+ 'type': 'executable',
+ 'dependencies': [
+ 'chrome_dll',
+ ],
+ # In release, we end up with a strip step that is unhappy if there is
+ # no binary. Rather than check in a new file for this hack, just
+ # generate a source file on the fly.
+ 'actions': [
+ {
+ 'action_name': 'generate_stub_main',
+ 'process_outputs_as_sources': 1,
+ 'inputs': [],
+ 'outputs': [ '<(INTERMEDIATE_DIR)/dummy_main.c' ],
+ 'action': [
+ 'bash', '-c',
+ 'echo "int main() { return 0; }" > <(INTERMEDIATE_DIR)/dummy_main.c'
+ ],
+ },
+ ],
+ },
+ ],
+ },
+ ],
['OS=="mac" or OS=="win"', {
'targets': [
{

Powered by Google App Engine
This is Rietveld 408576698