chrome/BUILD.gn - Issue 1412803002: Switch Chrome to dlopen() the Google Chrome Framework.framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1412803002: Switch Chrome to dlopen() the Google Chrome Framework.framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a shim so that Chrome does not link chrome_dll Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 8816e81abbcb867fffad8d78c5c0cbed1bc8be27..58b1995ed953feb573a3f0e24514363b04a229cc 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -209,7 +209,7 @@ if (!is_android) {

}

if (is_mac) {

- sources += [ "app/chrome_exe_main_mac.cc" ]

+ sources += [ "app/chrome_exe_main_mac.c" ]

deps += [ ":chrome_dll" ]

# TODO(GYP) lots more stuff in the is_mac block.

« no previous file with comments | « build/filename_rules.gypi ('k') | chrome/app/chrome_exe_main_mac.c » ('j') | chrome/app/chrome_exe_main_mac.c » ('J')