Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 14128006: Disable AutofillDialogCocoaBrowserTest.DisplayUI on ASan. (Closed)

Created:
7 years, 8 months ago by markusheintz_
Modified:
6 years, 11 months ago
CC:
chromium-reviews, sail+watch_chromium.org, groby-ooo-7-16
Visibility:
Public.

Description

Disable AutofillDialogCocoaBrowserTest.DisplayUI on ASan. BUG=234980

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : Disable 'run all plugins' link on the corresponding bubble if the setting in managed by policy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 2 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
markusheintz_
Please review this CL. Thanks.
7 years, 8 months ago (2013-04-24 10:20:38 UTC) #1
jochen (gone - plz use gerrit)
why not just revert r196005?
7 years, 8 months ago (2013-04-24 12:19:22 UTC) #2
markusheintz_
On 2013/04/24 12:19:22, jochen wrote: > why not just revert r196005? Because I don't know ...
7 years, 8 months ago (2013-04-24 12:29:57 UTC) #3
markusheintz_
On 2013/04/24 12:29:57, markusheintz_ wrote: > On 2013/04/24 12:19:22, jochen wrote: > > why not ...
7 years, 8 months ago (2013-04-24 12:32:17 UTC) #4
groby-ooo-7-16
7 years, 8 months ago (2013-04-24 15:38:50 UTC) #5
Message was sent while issue was closed.
This is indeed the culprit - taking over the bug.

Powered by Google App Engine
This is Rietveld 408576698