Issue 1412793003: Merge to XFA: Sanity check the values of TRUE and FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1412793003: Merge to XFA: Sanity check the values of TRUE and FALSE. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Sanity check the values of TRUE and FALSE. Get rid of cond ? TRUE : FALSE. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1405723003 . (cherry picked from commit aff4635dad81bc319266d9d84b81552580cd2b65) Committed: https://pdfium.googlesource.com/pdfium/+/b0748bb1b207559deaec7a5f49c00c492a5f6082

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -12 lines)			Patch
M	core/include/fxcrt/fx_system.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	core/include/fxge/fx_dib.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fpdfdoc/doc_vt.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_Context.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxge/dib/fx_dib_composite.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	core/src/fxge/dib/fx_dib_convert.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxge/win32/fx_win32_dwrite.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as b0748bb1b207559deaec7a5f49c00c492a5f6082 (presubmit successful).

5 years, 2 months ago (2015-10-19 19:11:52 UTC) #1

Lei Zhang

5 years, 2 months ago (2015-10-19 19:12:05 UTC) #2

Message was sent while issue was closed.

TBR, clean merge.

We'll need to do another pass for XFA.