Make CFX_FontMgr member variables private. (try 2)

core/include/fxge/fx_font.h

Index: core/include/fxge/fx_font.h
diff --git a/core/include/fxge/fx_font.h b/core/include/fxge/fx_font.h
index f36801584dabe38320937b1669d26bd9bd7e646b..7541af177d2dd16ecaf592b8304005139a1a8318 100644
--- a/core/include/fxge/fx_font.h
+++ b/core/include/fxge/fx_font.h
@@ -176,7 +176,7 @@ class CFX_FontMgr {
  public:
   CFX_FontMgr();
   ~CFX_FontMgr();
-  void InitFTLibrary();
+
   FXFT_Face GetCachedFace(const CFX_ByteString& face_name,
                           int weight,
                           FX_BOOL bItalic,
@@ -207,13 +207,17 @@ class CFX_FontMgr {
                           int italic_angle,
                           int CharsetCP,
                           CFX_SubstFont* pSubstFont);
-  void FreeCache();
   FX_BOOL GetStandardFont(const uint8_t*& pFontData, FX_DWORD& size, int index);
+  CFX_FontMapper* GetBuiltinMapper() const { return m_pBuiltinMapper; }
+  FXFT_Library GetFTLibrary() const { return m_FTLibrary; }
+
+ private:
+  void InitFTLibrary();
 
+  // TODO(thestig): Figure out why making this a unique_ptr does not work.
   CFX_FontMapper* m_pBuiltinMapper;

[Lei Zhang, 2015/10/20 18:13:31]

I bet someone is abusing GetBuiltinMapper(). Will figure that out separately.

[Lei Zhang, 2015/10/20 22:12:15]

Well, I lost that bet. Good thing I didn't go all in.

   std::map<CFX_ByteString, CTTFontDesc*> m_FaceMap;
   FXFT_Library m_FTLibrary;
-  FoxitFonts m_ExternalFonts[16];
 };
 
 class IFX_FontEnumerator {