Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412733011: Make CFX_FontMgr member variables private. (try 2) (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : previous try #

Patch Set 2 : no unique_ptr #

Total comments: 5

Patch Set 3 : delete in the right order, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -104 lines) Patch
M core/include/fxge/fx_font.h View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 2 chunks +13 lines, -19 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 2 5 chunks +37 lines, -67 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 2 1 chunk +15 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
https://codereview.chromium.org/1412733011/diff/20001/core/include/fxge/fx_font.h File core/include/fxge/fx_font.h (right): https://codereview.chromium.org/1412733011/diff/20001/core/include/fxge/fx_font.h#newcode218 core/include/fxge/fx_font.h:218: CFX_FontMapper* m_pBuiltinMapper; I bet someone is abusing GetBuiltinMapper(). Will ...
5 years, 2 months ago (2015-10-20 18:13:31 UTC) #1
Tom Sepez
https://codereview.chromium.org/1412733011/diff/20001/core/src/fxge/ge/fx_ge_fontmap.cpp File core/src/fxge/ge/fx_ge_fontmap.cpp (right): https://codereview.chromium.org/1412733011/diff/20001/core/src/fxge/ge/fx_ge_fontmap.cpp#newcode89 core/src/fxge/ge/fx_ge_fontmap.cpp:89: delete m_pBuiltinMapper; Do we want to do this after ...
5 years, 2 months ago (2015-10-20 18:58:24 UTC) #2
Lei Zhang
https://codereview.chromium.org/1412733011/diff/20001/core/src/fxge/ge/fx_ge_fontmap.cpp File core/src/fxge/ge/fx_ge_fontmap.cpp (right): https://codereview.chromium.org/1412733011/diff/20001/core/src/fxge/ge/fx_ge_fontmap.cpp#newcode89 core/src/fxge/ge/fx_ge_fontmap.cpp:89: delete m_pBuiltinMapper; On 2015/10/20 18:58:24, Tom Sepez wrote: > ...
5 years, 2 months ago (2015-10-20 19:13:58 UTC) #3
Lei Zhang
The patchset 3 to 1 diff is best. https://codereview.chromium.org/1412733011/diff/20001/core/include/fxge/fx_font.h File core/include/fxge/fx_font.h (right): https://codereview.chromium.org/1412733011/diff/20001/core/include/fxge/fx_font.h#newcode218 core/include/fxge/fx_font.h:218: CFX_FontMapper* ...
5 years, 2 months ago (2015-10-20 22:12:15 UTC) #4
Tom Sepez
Makes sense. LGTM.
5 years, 2 months ago (2015-10-20 22:43:41 UTC) #5
Lei Zhang
5 years, 2 months ago (2015-10-20 23:56:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
5a5b6fb3759daf1201ffc9702f626f4b243922d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698