Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/thread_test.cc

Issue 1412733008: Switch profiler from isolates to threads (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/thread_interrupter_win.cc ('K') | « runtime/vm/thread_interrupter_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_test.cc
diff --git a/runtime/vm/thread_test.cc b/runtime/vm/thread_test.cc
index 9eaf79138cff317d4d6f5bcf017bab89e1c8da1e..576a351ec5af8158eaad6fd7202de5ed282e2f5d 100644
--- a/runtime/vm/thread_test.cc
+++ b/runtime/vm/thread_test.cc
@@ -39,10 +39,7 @@ UNIT_TEST_CASE(Monitor) {
Dart_CreateIsolate(
NULL, NULL, bin::isolate_snapshot_buffer, NULL, NULL, NULL);
Thread* thread = Thread::Current();
- Isolate* isolate = thread->isolate();
- // Thread interrupter interferes with this test, disable interrupts.
Ivan Posva 2015/10/28 19:31:54 We might want to keep this comment.
Cutch 2015/10/28 19:50:33 Done.
- thread->SetThreadInterrupter(NULL, NULL);
- Profiler::EndExecution(isolate);
+ thread->DisableThreadInterrupts();
Monitor* monitor = new Monitor();
monitor->Enter();
monitor->Exit();
« runtime/vm/thread_interrupter_win.cc ('K') | « runtime/vm/thread_interrupter_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698