Switch profiler from isolates to threads

runtime/vm/thread_interrupter_win.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "vm/flags.h"
 #include "vm/os.h"
+#include "vm/profiler.h"
 #include "vm/thread_interrupter.h"
 
+

[siva, 2015/10/29 21:47:41]

extra blank line?

[Cutch, 2015/11/02 20:47:12]

Done.

 namespace dart {
 
 DECLARE_FLAG(bool, thread_interrupter);
 DECLARE_FLAG(bool, trace_thread_interrupter);
 
 #define kThreadError -1
 
 class ThreadInterrupterWin : public AllStatic {
  public:
   static bool GrabRegisters(HANDLE handle, InterruptedThreadState* state) {
@@ skipping 40 matching lines @@
     DWORD result = SuspendThread(handle);
     if (result == kThreadError) {
       if (FLAG_trace_thread_interrupter) {
         OS::Print("ThreadInterrupter failed to suspend thread %p\n",
                   reinterpret_cast<void*>(thread->id()));
       }
       CloseHandle(handle);
       return;
     }
     InterruptedThreadState its;
-    its.tid = thread->id();
     if (!GrabRegisters(handle, &its)) {
       // Failed to get thread registers.
       ResumeThread(handle);
       if (FLAG_trace_thread_interrupter) {
         OS::Print("ThreadInterrupter failed to get registers for %p\n",
                   reinterpret_cast<void*>(thread->id()));
       }
       CloseHandle(handle);
       return;
     }
-    ThreadInterruptCallback callback = NULL;
-    void* callback_data = NULL;
-    if (thread->IsThreadInterrupterEnabled(&callback, &callback_data)) {
-      callback(its, callback_data);
-    }
+    Profiler::SampleThread(thread, its);
     ResumeThread(handle);
     CloseHandle(handle);
   }
 };
 
 
 void ThreadInterrupter::InterruptThread(Thread* thread) {
   if (FLAG_trace_thread_interrupter) {
     OS::Print("ThreadInterrupter suspending %p\n",
               reinterpret_cast<void*>(thread->id()));
@@ skipping 13 matching lines @@
 
 void ThreadInterrupter::RemoveSignalHandler() {
   // Nothing to do on Windows.
 }
 
 
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)